Allow setting platform constraints with --exec_constraints #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coeuvre
requested review from
DaveGay,
eytankidron,
rbe-toolchains-pr-bot and
smukherj1
as code owners
coeuvre
force-pushed
the
set-exec-constraints
branch
from
f5a85a5
to
91f4d92
Compare
coeuvre
requested review from
philwo
and removed request for
smukherj1,
DaveGay,
eytankidron and
rbe-toolchains-pr-bot
coeuvre
force-pushed
the
set-exec-constraints
branch
from
ba39da9
to
ae4effc
Compare
coeuvre
force-pushed
the
set-exec-constraints
branch
from
ae4effc
to
7a3da83
Compare
|
I would be delighted to have this feature. |
coeuvre
force-pushed
the
set-exec-constraints
branch
from
7a3da83
to
8a81aa9
Compare
|
I have rebased the PR. Please review and let me know whether it's feasible to merge! |
coeuvre
force-pushed
the
set-exec-constraints
branch
from
8a81aa9
to
39f6363
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
clangis detected for cpp configs. While--cpp_env_jsoncan be used to override the default environment variables during toolchain generation, there isn't a way to override platform constraints.This PR adds flag
--exec_constraintswhich accept a comma separated list of constraint values e.g.--exec_constraints=@bazel_tools//platforms:linux,@bazel_tools//platforms:x86_64,@bazel_tools//tools/cpp:gccto override the default values.