23514 Override input label and text + fix pronoun #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
severinbeauvais
changed the title
severinbeauvais
force-pushed
the
23514
branch
from
feb8fc9 to
acbe0e2
Compare
- imported new shared Approval Type component (with lint fix) - imported new shared Certify component (with pronoun and colour fix) - updated entity display (per Jacqueline)
severinbeauvais
force-pushed
the
23514
branch
from
acbe0e2 to
f9e0c62
Compare
|
/gcbrun |
severinbeauvais
commented
Oct 10, 2024
| "@bcrs-shared-components/base-address": "2.0.3", | ||
| "@bcrs-shared-components/breadcrumb": "2.1.15", | ||
| "@bcrs-shared-components/business-lookup": "1.3.4", | ||
| "@bcrs-shared-components/certify": "2.1.15", | ||
| "@bcrs-shared-components/certify": "2.1.51", |
There was a problem hiding this comment.
The new shared component changed "is authorized" to "are authorized" and fixed the input colours per accessibility standards.
Before:
After:
severinbeauvais
commented
Oct 10, 2024
| @@ -35,7 +35,7 @@ export const ContinuationInResourceC: ContinuationInResourceIF = { | |||
| completingPartyStatement: { | |||
| certifyStatements: [], | |||
| certifyClause: ResourcePhrases.OFFENCE_SECTION_427, | |||
| entityDisplay: null | |||
| entityDisplay: 'business' | |||
There was a problem hiding this comment.
Before:
After:
severinbeauvais
commented
Oct 10, 2024
| @@ -14,11 +14,11 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@babel/compat-data": "^7.21.5", | |||
| "@bcrs-shared-components/approval-type": "1.1.2", | |||
| "@bcrs-shared-components/approval-type": "1.1.3", | |||
There was a problem hiding this comment.
Just a lint fix in this shared component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#23514
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).