Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23514 Override input label and text + fix pronoun #746

Merged
merged 1 commit into from
Oct 10, 2024
Merged

23514 Override input label and text + fix pronoun #746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 22 additions & 36 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-create-ui",
"version": "5.12.3",
"version": "5.12.4",
"private": true,
"appName": "Create UI",
"sbcName": "SBC Common Components",
Expand All @@ -14,11 +14,11 @@
},
"dependencies": {
"@babel/compat-data": "^7.21.5",
"@bcrs-shared-components/approval-type": "1.1.2",
"@bcrs-shared-components/approval-type": "1.1.3",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a lint fix in this shared component.

"@bcrs-shared-components/base-address": "2.0.3",
"@bcrs-shared-components/breadcrumb": "2.1.15",
"@bcrs-shared-components/business-lookup": "1.3.4",
"@bcrs-shared-components/certify": "2.1.15",
"@bcrs-shared-components/certify": "2.1.51",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new shared component changed "is authorized" to "are authorized" and fixed the input colours per accessibility standards.

Before:
image

After:
image

"@bcrs-shared-components/completing-party": "2.1.30",
"@bcrs-shared-components/confirm-dialog": "1.2.1",
"@bcrs-shared-components/contact-info": "1.2.15",
Expand Down
2 changes: 1 addition & 1 deletion src/resources/ContinuationIn/C.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const ContinuationInResourceC: ContinuationInResourceIF = {
completingPartyStatement: {
certifyStatements: [],
certifyClause: ResourcePhrases.OFFENCE_SECTION_427,
entityDisplay: null
entityDisplay: 'business'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:
image

After:
image

}
}
}
2 changes: 1 addition & 1 deletion src/resources/ContinuationIn/CBEN.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const ContinuationInResourceCben: ContinuationInResourceIF = {
completingPartyStatement: {
certifyStatements: [],
certifyClause: ResourcePhrases.OFFENCE_SECTION_427,
entityDisplay: null
entityDisplay: 'business'
}
}
}
2 changes: 1 addition & 1 deletion src/resources/ContinuationIn/CCC.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const ContinuationInResourceCcc: ContinuationInResourceIF = {
completingPartyStatement: {
certifyStatements: [],
certifyClause: ResourcePhrases.OFFENCE_SECTION_427,
entityDisplay: null
entityDisplay: 'business'
}
}
}
2 changes: 1 addition & 1 deletion src/resources/ContinuationIn/CUL.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const ContinuationInResourceCul: ContinuationInResourceIF = {
completingPartyStatement: {
certifyStatements: [],
certifyClause: ResourcePhrases.OFFENCE_SECTION_427,
entityDisplay: null
entityDisplay: 'business'
}
}
}
Loading