22639 - Update Certify Section Wording

[ArwenQin]

Issue #: /bcgov/entity#22639

Description of changes:

• Update Certify section for Create UI

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

[severinbeauvais]

I think that maybe, here, you could make entityDisplay optional and display the provided string (for CP, SP and GP) else fall back to "business". What do you think?

[ArwenQin]

I think that maybe, here, you could make entityDisplay optional and display the provided string (for CP, SP and GP) else fall back to "business". What do you think?

Agree, thanks! I updated the codes

[ArwenQin]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://business-create-dev--pr-758-as4ni3qx.web.app

[ArwenQin]

The current dev correctly display the required wording ("are" authorized). Maybe we don't need to update it to 2.1.55.
But when I run locally, it displays "is" instead of "are".

Could you please suggest, thanks.

[severinbeauvais]

Check your node_modules folder. You might have an older version than 51.

As for whether to upgrade from 51 to 55...

• on the one hand, it's good to keep these imports updated
• on the other hand, did very much change from 51 to 55? if so then extra testing is needed

If there are no significant changes from 51 to 55 then I leave it up to you whether to upgrade it.

[ArwenQin]

It seems there are no changes from 51 to 55. They were updated just due to the chore(release) publish

[severinbeauvais]

That likely means some dependency was updated (eg, enums or interfaces).

Up to you whether to update to 55 or not.

[ArwenQin]

So I leave it upgraded

[severinbeauvais]

I think that maybe, here, you could make entityDisplay optional and display the provided string (for CP, SP and GP) else fall back to "business". What do you think?

Agree, thanks! I updated the codes

Well, darn! That's even more changed files.

But I prefer this as it's DRYer and cleaner. Thanks for the update!

[ArwenQin]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://business-create-dev--pr-758-as4ni3qx.web.app