Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22639 - Update Certify Section Wording #758

Merged
merged 6 commits into from
Nov 14, 2024
Merged

22639 - Update Certify Section Wording #758

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
104bee3
update companies to display business
ArwenQin Nov 13, 2024
0c8b067
update certify version
ArwenQin Nov 13, 2024
e536d3c
update wording for restoration
ArwenQin Nov 14, 2024
e2eb2d7
update package version
ArwenQin Nov 14, 2024
362b3f5
update code structure
ArwenQin Nov 14, 2024
4383a96
update firm component
ArwenQin Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-create-ui",
"version": "5.14.2",
"version": "5.14.3",
"private": true,
"appName": "Create UI",
"sbcName": "SBC Common Components",
Expand All @@ -22,7 +22,7 @@
"@bcrs-shared-components/base-address": "2.0.3",
"@bcrs-shared-components/breadcrumb": "2.1.15",
"@bcrs-shared-components/business-lookup": "1.3.4",
"@bcrs-shared-components/certify": "2.1.51",
"@bcrs-shared-components/certify": "2.1.55",
"@bcrs-shared-components/completing-party": "2.1.30",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current dev correctly display the required wording ("are" authorized). Maybe we don't need to update it to 2.1.55.
But when I run locally, it displays "is" instead of "are".

Could you please suggest, thanks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check your node_modules folder. You might have an older version than 51.

As for whether to upgrade from 51 to 55...

  • on the one hand, it's good to keep these imports updated
  • on the other hand, did very much change from 51 to 55? if so then extra testing is needed

If there are no significant changes from 51 to 55 then I leave it up to you whether to upgrade it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there are no changes from 51 to 55. They were updated just due to the chore(release) publish
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That likely means some dependency was updated (eg, enums or interfaces).

Up to you whether to update to 55 or not.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I leave it upgraded

"@bcrs-shared-components/confirm-dialog": "1.2.1",
"@bcrs-shared-components/contact-info": "1.2.15",
Expand Down
2 changes: 1 addition & 1 deletion src/resources/Dissolution/BC.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const DissolutionResourceBc: DissolutionResourceIF = {
completingPartyStatement: {
certifyStatements: [],
certifyClause: ResourcePhrases.OFFENCE_SECTION_427,
entityDisplay: GetCorpFullDescription(CorpTypeCd.BC_COMPANY)
entityDisplay: 'business'
}
},
createResolution: {
Expand Down
2 changes: 1 addition & 1 deletion src/resources/Dissolution/BEN.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export const DissolutionResourceBen: DissolutionResourceIF = {
completingPartyStatement: {
certifyStatements: [],
certifyClause: ResourcePhrases.OFFENCE_SECTION_427,
entityDisplay: GetCorpFullDescription(CorpTypeCd.BENEFIT_COMPANY)
entityDisplay: 'business'
}
},
createResolution: {
Expand Down
2 changes: 1 addition & 1 deletion src/resources/Dissolution/C.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const DissolutionResourceC: DissolutionResourceIF = {
completingPartyStatement: {
certifyStatements: [],
certifyClause: ResourcePhrases.OFFENCE_SECTION_427,
entityDisplay: GetCorpFullDescription(CorpTypeCd.CONTINUE_IN)
entityDisplay: 'business'
}
},
createResolution: {
Expand Down
2 changes: 1 addition & 1 deletion src/resources/Dissolution/CBEN.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export const DissolutionResourceCben: DissolutionResourceIF = {
completingPartyStatement: {
certifyStatements: [],
certifyClause: ResourcePhrases.OFFENCE_SECTION_427,
entityDisplay: GetCorpFullDescription(CorpTypeCd.BEN_CONTINUE_IN)
entityDisplay: 'business'
}
},
createResolution: {
Expand Down
2 changes: 1 addition & 1 deletion src/resources/Dissolution/CC.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const DissolutionResourceCc: DissolutionResourceIF = {
completingPartyStatement: {
certifyStatements: [],
certifyClause: ResourcePhrases.OFFENCE_SECTION_427,
entityDisplay: GetCorpFullDescription(CorpTypeCd.BC_CCC)
entityDisplay: 'business'
}
},
createResolution: {
Expand Down
2 changes: 1 addition & 1 deletion src/resources/Dissolution/CCC.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const DissolutionResourceCcc: DissolutionResourceIF = {
completingPartyStatement: {
certifyStatements: [],
certifyClause: ResourcePhrases.OFFENCE_SECTION_427,
entityDisplay: GetCorpFullDescription(CorpTypeCd.CCC_CONTINUE_IN)
entityDisplay: 'business'
}
},
createResolution: {
Expand Down
2 changes: 1 addition & 1 deletion src/resources/Dissolution/CUL.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const DissolutionResourceCul: DissolutionResourceIF = {
completingPartyStatement: {
certifyStatements: [],
certifyClause: ResourcePhrases.OFFENCE_SECTION_427,
entityDisplay: GetCorpFullDescription(CorpTypeCd.ULC_CONTINUE_IN)
entityDisplay: 'business'
}
},
createResolution: {
Expand Down
2 changes: 1 addition & 1 deletion src/resources/Dissolution/ULC.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const DissolutionResourceUlc: DissolutionResourceIF = {
completingPartyStatement: {
certifyStatements: [],
certifyClause: ResourcePhrases.OFFENCE_SECTION_427,
entityDisplay: GetCorpFullDescription(CorpTypeCd.BC_ULC_COMPANY)
entityDisplay: 'business'
}
},
createResolution: {
Expand Down
2 changes: 1 addition & 1 deletion src/resources/Incorporation/BC.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export const IncorporationResourceBc: IncorporationResourceIF = {
ResourcePhrases.RELEVANT_KNOWLEDGE_OF_COMPANY
],
certifyClause: ResourcePhrases.OFFENCE_SECTION_427,
entityDisplay: null
entityDisplay: 'business'
}
}
}
2 changes: 1 addition & 1 deletion src/resources/Incorporation/BEN.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export const IncorporationResourceBen: IncorporationResourceIF = {
ResourcePhrases.RELEVANT_KNOWLEDGE_OF_COMPANY
],
certifyClause: ResourcePhrases.OFFENCE_SECTION_427,
entityDisplay: null
entityDisplay: 'business'
}
}
}
2 changes: 1 addition & 1 deletion src/resources/Incorporation/CC.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export const IncorporationResourceCc: IncorporationResourceIF = {
ResourcePhrases.RELEVANT_KNOWLEDGE_OF_COMPANY
],
certifyClause: ResourcePhrases.OFFENCE_SECTION_427,
entityDisplay: null
entityDisplay: 'business'
}
}
}
2 changes: 1 addition & 1 deletion src/resources/Incorporation/ULC.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export const IncorporationResourceUlc: IncorporationResourceIF = {
ResourcePhrases.RELEVANT_KNOWLEDGE_OF_COMPANY
],
certifyClause: ResourcePhrases.OFFENCE_SECTION_427,
entityDisplay: null
entityDisplay: 'business'
}
}
}
2 changes: 1 addition & 1 deletion src/resources/Restoration/BC.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const RestorationResourceBc: RestorationResourceIF = {
certifyClause: `Note: It is an offence to make or assist in making a false or misleading
statement in a record filed under the BC Corporations Act. A person who commits this
offence is subject to a maximum fine of $5,000.`,
entityDisplay: 'BC Corporations Act'
severinbeauvais marked this conversation as resolved.
Show resolved Hide resolved
entityDisplay: 'business'
}
}
}
2 changes: 1 addition & 1 deletion src/resources/Restoration/BEN.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const RestorationResourceBen: RestorationResourceIF = {
certifyClause: `Note: It is an offence to make or assist in making a false or misleading
statement in a record filed under the BC Corporations Act. A person who commits this
offence is subject to a maximum fine of $5,000.`,
entityDisplay: 'BC Corporations Act'
entityDisplay: 'business'
}
}
}
2 changes: 1 addition & 1 deletion src/resources/Restoration/C.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const RestorationResourceC: RestorationResourceIF = {
certifyClause: `Note: It is an offence to make or assist in making a false or misleading
statement in a record filed under the BC Corporations Act. A person who commits this
offence is subject to a maximum fine of $5,000.`,
entityDisplay: 'BC Corporations Act'
entityDisplay: 'business'
}
}
}
2 changes: 1 addition & 1 deletion src/resources/Restoration/CBEN.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const RestorationResourceCben: RestorationResourceIF = {
certifyClause: `Note: It is an offence to make or assist in making a false or misleading
statement in a record filed under the BC Corporations Act. A person who commits this
offence is subject to a maximum fine of $5,000.`,
entityDisplay: 'BC Corporations Act'
entityDisplay: 'business'
}
}
}
2 changes: 1 addition & 1 deletion src/resources/Restoration/CC.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const RestorationResourceCc: RestorationResourceIF = {
certifyClause: `Note: It is an offence to make or assist in making a false or misleading
statement in a record filed under the BC Corporations Act. A person who commits this
offence is subject to a maximum fine of $5,000.`,
entityDisplay: 'BC Corporations Act'
entityDisplay: 'business'
}
}
}
2 changes: 1 addition & 1 deletion src/resources/Restoration/CCC.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const RestorationResourceCcc: RestorationResourceIF = {
certifyClause: `Note: It is an offence to make or assist in making a false or misleading
statement in a record filed under the BC Corporations Act. A person who commits this
offence is subject to a maximum fine of $5,000.`,
entityDisplay: 'BC Corporations Act'
entityDisplay: 'business'
}
}
}
2 changes: 1 addition & 1 deletion src/resources/Restoration/CUL.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const RestorationResourceCul: RestorationResourceIF = {
certifyClause: `Note: It is an offence to make or assist in making a false or misleading
statement in a record filed under the BC Corporations Act. A person who commits this
offence is subject to a maximum fine of $5,000.`,
entityDisplay: 'BC Corporations Act'
entityDisplay: 'business'
}
}
}
2 changes: 1 addition & 1 deletion src/resources/Restoration/ULC.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const RestorationResourceUlc: RestorationResourceIF = {
certifyClause: `Note: It is an offence to make or assist in making a false or misleading
statement in a record filed under the BC Corporations Act. A person who commits this
offence is subject to a maximum fine of $5,000.`,
entityDisplay: 'BC Corporations Act'
entityDisplay: 'business'
}
}
}
Loading