Skip to content

Commit

Permalink
Implements Base completing party (#259)
Browse files Browse the repository at this point in the history
  • Loading branch information
cameron-eyds authored Apr 21, 2022
1 parent f556d7e commit 233d102
Show file tree
Hide file tree
Showing 7 changed files with 121 additions and 25 deletions.
86 changes: 74 additions & 12 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-edit-ui",
"version": "2.1.7",
"version": "2.1.8",
"private": true,
"appName": "Edit UI",
"sbcName": "SBC Common Components",
Expand All @@ -17,6 +17,7 @@
"@bcrs-shared-components/action-chip": "1.0.6",
"@bcrs-shared-components/bread-crumb": "1.0.1",
"@bcrs-shared-components/certify": "1.0.18",
"@bcrs-shared-components/completing-party": "1.0.1",
"@bcrs-shared-components/confirm-dialog": "1.1.0",
"@bcrs-shared-components/contact-info": "1.1.2",
"@bcrs-shared-components/corp-type-module": "1.0.6",
Expand All @@ -26,7 +27,7 @@
"@bcrs-shared-components/enums": "1.0.17",
"@bcrs-shared-components/fee-summary": "1.1.15",
"@bcrs-shared-components/folio-number": "1.0.0",
"@bcrs-shared-components/interfaces": "1.0.33",
"@bcrs-shared-components/interfaces": "1.0.34",
"@bcrs-shared-components/nature-of-business": "1.0.3",
"@bcrs-shared-components/share-structure": "1.0.20",
"@bcrs-shared-components/staff-payment": "1.0.35",
Expand Down
1 change: 1 addition & 0 deletions src/components/Edit/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ export { default as ChangeSummary } from './ChangeSummary.vue'
export { default as DocumentsDelivery } from './DocumentsDelivery.vue'
export { default as TransactionalFolioNumber } from './TransactionalFolioNumber.vue'
export { default as NatureOfBusiness } from './NatureOfBusiness.vue'
export { CompletingParty } from '@bcrs-shared-components/completing-party'
1 change: 1 addition & 0 deletions src/interfaces/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export * from './utils-interfaces'
export * from './state-interface'
export type {
BreadcrumbIF,
CompletingPartyIF,
ContactPointIF,
NaicsIF,
NaicsResultIF,
Expand Down

This file was deleted.

2 changes: 1 addition & 1 deletion src/mixins/filing-template-mixin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ export default class FilingTemplateMixin extends Mixins(DateMixin) {
return rest
})
}
console.log(parties)

filing.changeOfRegistration.parties = parties
}

Expand Down
43 changes: 41 additions & 2 deletions src/views/Change.vue
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,20 @@
@valid="setDocumentOptionalEmailValidity($event)"
/>

<section id="completing-party-section">
<h2>2. Completing Party</h2>
<v-card flat>
<CompletingParty
class="mt-6 pb-0"
:currentCompletingParty="mockCompletingParty"
:enableAddEdit="isRoleStaff"
:addressSchema="PersonAddressSchema"
:validate="getAppValidate"
@addEditCompletingParty="addEditCompletingParty($event)"
/>
</v-card>
</section>

<CertifySection
class="mt-10"
:sectionNumber="showTransactionalFolioNumber ? '3.' : '2.'"
Expand All @@ -59,11 +73,11 @@
import { Component, Emit, Mixins, Prop, Vue, Watch } from 'vue-property-decorator'
import { Action, Getter } from 'vuex-class'
import { getFeatureFlag } from '@/utils'
import { ChangeSummary, DocumentsDelivery, TransactionalFolioNumber } from '@/components/Edit'
import { ChangeSummary, CompletingParty, DocumentsDelivery, TransactionalFolioNumber } from '@/components/Edit'
import { CertifySection, PeopleAndRoles, StaffPayment, YourCompany } from '@/components/common'
import { AuthApiMixin, CommonMixin, FilingTemplateMixin, LegalApiMixin, PayApiMixin } from '@/mixins'
import {
ActionBindingIF,
ActionBindingIF, CompletingPartyIF,
EffectiveDateTimeIF,
EmptyFees,
EntitySnapshotIF,
Expand All @@ -75,11 +89,13 @@ import { CorpTypeCd, FilingCodes, FilingStatus, OrgPersonTypes } from '@/enums'
import { SessionStorageKeys } from 'sbc-common-components/src/util/constants'
import { cloneDeep } from 'lodash'
import { ChangeFirmResources } from '@/resources'
import { PersonAddressSchema } from '@/schemas'
@Component({
components: {
CertifySection,
ChangeSummary,
CompletingParty,
DocumentsDelivery,
PeopleAndRoles,
StaffPayment,
Expand Down Expand Up @@ -120,6 +136,24 @@ export default class Change extends Mixins(
@Action setFeePrices!: ActionBindingIF
@Action setResource!: ActionBindingIF
private PersonAddressSchema = PersonAddressSchema
// TODO: Remove/Replace with structured data from Account (ie First, middle, last name & Mailing Address)
private mockCompletingParty = {
firstName: 'Steve',
middleName: 'D',
lastName: 'Jobs',
mailingAddress: {
addressCity: 'Victoria',
addressCountry: 'Canada',
addressRegion: 'BC',
deliveryInstructions: 'Test test test',
postalCode: 'V8V 1s8',
streetAddress: '1234',
streetAddressAdditional: 'Test Street Additional'
}
}
/** Whether App is ready. */
@Prop({ default: false })
readonly appReady: boolean
Expand Down Expand Up @@ -250,6 +284,11 @@ export default class Change extends Mixins(
}
}
private addEditCompletingParty (event: CompletingPartyIF): void {
// Apply new completing party to store.
// Will require formatting and adding to the peopleAndRoles, see 'OrgPersonIF'
}
/** Emits Fetch Error event. */
@Emit('fetchError')
private emitFetchError (message: string = ''): void { }
Expand Down

0 comments on commit 233d102

Please sign in to comment.