24041 Fix alteration of company type issues #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leodube-aot
requested review from
severinbeauvais,
vysakh-menon-aot,
JazzarKarim and
meawong
JazzarKarim
approved these changes
Nov 12, 2024
vysakh-menon-aot
approved these changes
Nov 12, 2024
|
/gcbrun |
|
Temporary Url for review: https://business-edit-dev--pr-597-r4jfzs0y.web.app |
meawong
approved these changes
Nov 12, 2024
| @@ -459,7 +459,7 @@ export default class ChangeBusinessType extends Mixins(CommonMixin) { | |||
| } | |||
| if (this.isCommunityContribution) { | |||
| originalName = originalName.replace(' LTD.', '') | |||
| originalName += ' COMMUNITY CONTRIBUTION COMPANY' | |||
| originalName += ' COMMUNITY CONTRIBUTION COMPANY LTD.' | |||
There was a problem hiding this comment.
I checked bcrs-shared-components and business-create-ui and no changes are needed there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#24041
Description of changes:
getUpdatedNamefor businesses altering their type to CC/CCC. Talked to Dylan and the preference is to use "COMMUNITY CONTRIBUTION COMPANY LTD." suffix for numbered companies.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).