generated from bcgov/bcrs-template-ui
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
25294 - Submit NoW for Bootstrap Filing #712
Merged
ArwenQin
merged 9 commits into
bcgov:main
from
ArwenQin:25294-Submit-NoW-for-Bootstrap-Filing
Jan 17, 2025
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
954af6a
handle bootstrap filing properties
ArwenQin 739c230
update unit tests
ArwenQin 850a0ef
update package version
ArwenQin 505ba19
remove not needed import
ArwenQin 42ee7a6
update legal name handling
ArwenQin 7b0b92f
update fallback to null
ArwenQin 0bec02e
update fallback to null 2
ArwenQin c4b58db
update default undefined value
ArwenQin 2f2e594
update default undefined value 2
ArwenQin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -168,7 +168,8 @@ import { | |
import { BreadcrumbIF } from '@bcrs-shared-components/interfaces' | ||
import { FilingStatus, NameRequestStates, NigsMessage, Routes } from '@/enums' | ||
import { FilingTypes } from '@bcrs-shared-components/enums' | ||
import { CorpTypeCd, GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module' | ||
import { CorpTypeCd, GetCorpFullDescription, GetCorpNumberedDescription } | ||
from '@bcrs-shared-components/corp-type-module' | ||
import { SessionStorageKeys } from 'sbc-common-components/src/util/constants' | ||
import { useBusinessStore, useConfigurationStore, useFilingHistoryListStore, useRootStore } from './stores' | ||
|
||
|
@@ -371,6 +372,7 @@ export default class App extends Mixins( | |
@Action(useBusinessStore) setLegalName!: (x: string) => Promise<void> | ||
@Action(useBusinessStore) setLegalType!: (x: CorpTypeCd) => Promise<void> | ||
@Action(useBusinessStore) setIdentifier!: (x: string) => Promise<void> | ||
@Action(useBusinessStore) setFoundingDate!: (x: string) => Promise<void> | ||
|
||
@Action(useFilingHistoryListStore) loadFilings!: (x: string) => Promise<void> | ||
@Action(useFilingHistoryListStore) setFilings!: (x: ApiFilingIF[]) => void | ||
|
@@ -624,6 +626,12 @@ export default class App extends Mixins( | |
const filing = response?.filing | ||
const filingName = filing.header?.name as FilingTypes | ||
const status = filing.header.status as FilingStatus | ||
const foundingDate = filing.header?.effectiveDate // use the FE date as the founding date | ||
const email = | ||
filing?.incorporationApplication?.contactPoint?.email || | ||
filing?.amalgamationApplication?.contactPoint?.email || | ||
filing?.continuationIn?.contactPoint?.email || | ||
filing?.registration?.contactPoint?.email | ||
|
||
severinbeauvais marked this conversation as resolved.
Show resolved
Hide resolved
severinbeauvais marked this conversation as resolved.
Show resolved
Hide resolved
|
||
if (!filing || !filing.business || !filing.header || !filingName || !status) { | ||
throw new Error(`Invalid boostrap filing - missing required property = ${filing}`) | ||
|
@@ -656,12 +664,17 @@ export default class App extends Mixins( | |
this.setIdentifier(this.tempRegNumber) | ||
this.setLegalType(legalType) | ||
this.setGoodStanding(true) // draft apps are always in good standing | ||
this.setFoundingDate(foundingDate) | ||
this.setBusinessEmail(email) | ||
|
||
// save local NR Number if present | ||
if (nameRequest.nrNumber) this.localNrNumber = nameRequest.nrNumber | ||
|
||
// store Legal Name if present | ||
if (nameRequest.legalName) this.setLegalName(nameRequest.legalName) | ||
// special case to identify numbered amalgamations | ||
if (filingName === FilingTypes.AMALGAMATION_APPLICATION) { | ||
this.setLegalName(nameRequest.legalName || 'Numbered Amalgamated Company') | ||
} else { this.setLegalName(nameRequest.legalName || GetCorpNumberedDescription(this.getLegalType)) } | ||
|
||
ArwenQin marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
// store the bootstrap item in the right list | ||
if (this.isBootstrapTodo) this.storeBootstrapTodo(response) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the FE date as the founding date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great comment, thanks!