25294 - Submit NoW for Bootstrap Filing #712
Conversation
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
src/App.vue
Outdated
| @@ -624,6 +625,12 @@ export default class App extends Mixins( | |||
| const filing = response?.filing | |||
| const filingName = filing.header?.name as FilingTypes | |||
| const status = filing.header.status as FilingStatus | |||
| const foundingDate = filing.header?.effectiveDate // use the FE date as the founding date | |||
There was a problem hiding this comment.
Use the FE date as the founding date
There was a problem hiding this comment.
Great comment, thanks!
|
Can Submit now. Test: Amalgamation: https://business-filings-dev--pr-712-mw95fpzl.web.app/T8hhtIGwyy/notice-of-withdrawal?filingToBeWithdrawn=158447&filingId=0 Registration: Registrations can't be FE |
|
Still can't Save/ Save and Resume, probably a bug in Legal API - need a new ticket We experienced the similar issue before, probably an issue in Legal API |
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Qin <[email protected]>
| // special case to identify numbered amalgamations | ||
| if (filingName === FilingTypes.AMALGAMATION_APPLICATION) { | ||
| this.setLegalName(nameRequest.legalName || 'Numbered Amalgamated Company') | ||
| } else { this.setLegalName(nameRequest.legalName || GetCorpNumberedDescription(this.getLegalType)) } | ||
|
|
There was a problem hiding this comment.
Special case for numbered amalgamations, same as current set up in businessStore.ts:
other bootstraps, set legal name to numbered description, instead of null
Amalgamation (same as current display)
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
|
/gcbrun |
|
|
Temporary Url for review: https://business-filings-dev--pr-712-mw95fpzl.web.app |
Issue #: /bcgov/entity#25294
Description of changes:
Reason: Bootstrap filings don't have those 3 properties set up - founding date, legal name and Registered Office email.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).