reporting buttons fixes #2567

gdalcengio · 2024-12-10T22:18:56Z

fix: Fix reporting step buttons on attachments and allocation pages
test: update tests after reporting step buttons update

🔬 SH Post Review - Testing:

From terminal command, start the api server:

cd bc_obps
make reset_db
make run

From terminal command, start the app development server:

cd bciers && yarn dev-all

Navigate to http://localhost:3000
Click button "Log in with Business BCeID"
Navigate to http://localhost:3000/reporting/reports
Expected Results

Reporting grid displays with rows having action buttons Start or Continue

Click Operator 3 row button Start
Expected Results

Url does NOT display any query parameters such as`..?reports_title=...1
Router navigates to form: Review operation information
Form has buttons: Back; Save; Save & Continue

Navigate to http://localhost:3000/reporting/reports
Click Operator 3 row button Continue
Expected Results

Url does NOT display any query parameters such as`..?reports_title=...1
Router navigates to form: Review operation information
Form has buttons: Back; Save; Save & Continue

Click button Back
Expected Results

Router navigates to the previous next step

Click Operator 3 row button Continue
Click button Save
Expected Results

Form POST data to the server
Router does not navigate to the next step

Click button Save & Continue
Expected Results

Form POST data to the server
Router navigates to form: Person Responsible
Form has buttons: Back; Save; Save & Continue

Click button Back
Expected Results

Router navigates to the previous next step

Click button Save & Continue

Form POST data to the server
Router navigates to form: Person Responsible

Complete form and click button Save
Expected Results

Form POST data to the server
Router does not navigate to the next step

Click button Save & Continue
Expected Results

Form POST data to the server
Router navigates to form: Review facility information
Form has buttons: Back; Save; Save & Continue

Click button Back
Expected Results

Router navigates to the previous next step

Click button Save & Continue

Form POST data to the server
Router navigates to form: Review facility information

Complete form and click button Save
Expected Results

Form POST data to the server
Router does not navigate to the next step

Click button Save & Continue
Expected Results

Form POST data to the server
Router navigates to form: General stationary combustion excluding line tracing
Form has buttons: Back; Save; Save & Continue

Click button Back
Expected Results

Router navigates to the previous next step

Click button Save & Continue

Form POST data to the server
Router navigates to form: General stationary combustion excluding line tracing

Complete form and click button Save
Expected Results

Form POST data to the server
Router does not navigate to the next step

Click button Save & Continue
Expected Results

Form POST data to the server
Router navigates to form: Activities (currently "Something went wrong...")

Navigate to http://localhost:3000/reporting/reports/3/facilities/f486f2fb-62ed-438d-bb3e-0819b51e3aff/non-attributable

Router navigates to form: Non-Attributable Emissions
Form has buttons: Back; Save; Save & Continue

Complete form and click button Save
Expected Results

Form POST data to the server
Router does not navigate to the next step

Click button Save & Continue
Expected Results

Form POST data to the server
Router navigates to form: Emission Summary
Form has buttons: Back; Save; Continue
Button Save is disabled

Click button Continue
Expected Results

Router navigates to form: Production Data
Form has buttons: Back; Save; Save & Continue

Click button Back
Expected Results

Router navigates to the 'Emission Summary`

Click button Continue
Expected Results

Router navigates to form: Production Data

Complete form and click button Save
Expected Results

Form POST data to the server
Router does not navigate to the next step

Click button Save & Continue
Expected Results

Form POST data to the server
Router navigates to form; Allocation Of Emissions
Form has buttons: Back; Save; Save & Continue

Click button Back
Expected Results

Router navigates to the previous next step

Click button Save & Continue

Form POST data to the server
Router navigates to form: Allocation Of Emissions

Complete form and click button Save
Expected Results

Form POST data to the server
Router does not navigate to the next step

Click button Save & Continue
Expected Results

Form POST data to the server
Router navigates to form: Additional Reporting Data
Form has buttons: Back; Save; Save & Continue

Click button Back
Expected Results

Router navigates to the previous next step

Click button Save & Continue

Form POST data to the server
Router navigates to form: Additional Reporting Data

Complete form and click button Save
Expected Results

Form POST data to the server
Router does not navigate to the next step

Click button Save & Continue
Expected Results

Form POST data to the server
Router navigates to form: new-entrant-information (coming soon)
Form has buttons: Back; Save; Save & Continue

Navigate to http://localhost:3000/reporting/reports/3/verification
Expected Results

Router navigates to form: Verification
Form has buttons: Back; Save; Save & Continue

Complete form and click button Save
Expected Results

Form POST data to the server
Router does not navigate to the next step

Click button Save & Continue
Expected Results

Form POST data to the server
Router navigates to form; Attachments
Form has buttons: Back; Save; Save & Continue

Click button Back
Expected Results

Router navigates to the previous next step

Click button Save & Continue

Form POST data to the server
Router navigates to form: Attachments

Complete form and click button Save
Expected Results

Form POST data to the server
Router does not navigate to the next step

Click button Save & Continue
Expected Results

Form POST data to the server
Router navigates to form; Final Review
Form has buttons: Back; Save; Save & Continue

Click button Back
Expected Results

Router navigates to the previous next step

Click button Save & Continue

Form POST data to the server
Router navigates to form: Final Review

Complete form and click button Save
Expected Results

Router does not navigate to the next step

Click button Save & Continue
Expected Results

Router navigates to form; Sign Off
Form has buttons: Back; Save; Save & Continue
Button Save is disabled

Click button Back
Expected Results

Router navigates to the previous next step

Click button Save & Continue

Router navigates to form; Sign Off

Complete form and click button Save & Continue
Expected Results

Successful Submission displays

shon-button · 2024-12-11T15:39:31Z

bciers/apps/reporting/src/app/components/signOff/SignOffPage.tsx

@@ -29,11 +30,13 @@ const taskListElements: TaskListElement[] = [
  },
 ];

-export default function SignOffPage() {
+const SignOffPage: React.FC<HasReportVersion> = ({ version_id }) => {


@gdalcengio
For your consideration:
IMO, for Next.js apps, if your component is a page component, the preferred pattern is a function declaration with export default; such as, export default function SignOffPage({ version_id }: HasReportVersion) {...
This pattern aligns with the framework's dynamic routing and file-based conventions.

shon-button · 2024-12-11T16:01:03Z

@gdalcengio

Seems, this is still an issue:

Save and Save and Continue perform same routing function
http://localhost:3000/reporting/reports/3/facilities/f486f2fb-62ed-438d-bb3e-0819b51e3aff/production-data

shon-button · 2024-12-11T18:09:23Z

bciers/apps/reporting/src/app/components/facility/FacilityEmissionAllocationForm.tsx

@@ -236,8 +236,6 @@ export default function FacilityEmissionAllocationForm({
    setSubmitButtonDisabled(false);


@gdalcengio
FYI: Clicking Save disables the Save and Continue due to handleSubmit\setSubmitButtonDisabled(false);

shon-button · 2024-12-11T19:47:04Z

@gdalcengio

FYI, related to breadcrumb component, there are some navigation links with obsoletequery parameters no longer needed for reporting breadcrumbs (such as reports-titleandfacility_title`)

chore: fix additonal data back url chore: fix backURL chore: fix incorrect url

shon-button · 2024-12-11T22:31:46Z

@gdalcengio

Other components with button display and functionality issues:
AdditionalReportingDataForm
NonAttributableEmissionsForm
FinalReviewForm

shon-button · 2024-12-11T23:13:08Z

bciers/apps/reporting/src/app/components/operations/personResponsible/PersonResponsible.tsx

  const continueUrl =
    operationType === "Linear Facility Operation"
-      ? `/reporting/reports/${version_id}/facilities/lfo-facilities${queryString}`


FYI: incorrect /reporting/reports/ instead of /reports/

acatchpole

local testing confirms working. Only possible issue noticed is :
On 'Review Operation Information' page: clicking "Save" generates error =
An error occurred while fetching /reporting/report-version/3/report-operation: SyntaxError: Unexpected token '<', "
<!doctype "... is not valid JSON
- status 200 is still returned from the POST and seem to function properly. Behaviour is NOT seen when clicking "Save and Continue". probably not an issue that would be noticed in testing tomorrow

acatchpole · 2024-12-12T00:10:06Z

...app/components/additionalInformation/additionalReportingData/AdditionalReportingDataForm.tsx


+ */


commented code still present

shon-button · 2024-12-12T00:19:11Z

local testing confirms working. Only possible issue noticed is : On 'Review Operation Information' page: clicking "Save" generates error = An error occurred while fetching /reporting/report-version/3/report-operation: SyntaxError: Unexpected token '<', " <!doctype "... is not valid JSON - status 200 is still returned from the POST and seem to function properly. Behaviour is NOT seen when clicking "Save and Continue". probably not an issue that would be noticed in testing tomorrow

Thanks @acatchpole !
I can not reproduce "On 'Review Operation Information' page: clicking "Save" generates error"
but, I did notice that on page General stationary combustion excluding line tracing clicking "Save" without any data generates error.
I have a note to create a possible ticket(s)

chore: additional data chore: add test delay for CI pre-commit fix for CI fix for CI

shon-button · 2024-12-12T15:12:30Z

Capturing Additional Reporting Data buttons display in this branch:

gdalcengio · 2024-12-18T19:29:15Z

Thank you @shon-button. I really appreciate you cleaning up all the mess I left!

gdalcengio force-pushed the reporting_buttons_fixes branch from 3ef608e to f6b8ba1 Compare December 10, 2024 22:49

shon-button mentioned this pull request Dec 11, 2024

289 allocation of emissions bugs #2562

Merged

shon-button reviewed Dec 11, 2024

View reviewed changes

shon-button force-pushed the reporting_buttons_fixes branch from f6b8ba1 to 3089450 Compare December 11, 2024 17:55

shon-button reviewed Dec 11, 2024

View reviewed changes

shon-button force-pushed the reporting_buttons_fixes branch from 4052364 to 4711986 Compare December 11, 2024 20:00

gdalcengio and others added 5 commits December 11, 2024 17:01

fix: Fix reporting step buttons on attachments and allocation pages

d1097af

test: update tests after reporting step buttons update

275d90b

chore: quick sign off page update for reporting step buttons

099a579

chore: fix production data navigation

cc71d2d

chore: update grid actions to updated breadcrumbs

5c7c50e

shon-button force-pushed the reporting_buttons_fixes branch from 9949aa6 to 7777381 Compare December 11, 2024 22:01

shon-button added 2 commits December 11, 2024 17:03

chore: cleanup breadcrumb query params

718964e

chore: fix additonal data back url chore: fix backURL chore: fix incorrect url

chore: fix navigation buttons urls

6238498

shon-button force-pushed the reporting_buttons_fixes branch from 7777381 to 6238498 Compare December 11, 2024 22:03

shon-button force-pushed the reporting_buttons_fixes branch from bd1a0fe to eed0626 Compare December 11, 2024 23:10

shon-button reviewed Dec 11, 2024

View reviewed changes

acatchpole approved these changes Dec 12, 2024

View reviewed changes

chore: update additional data back button

bd961e9

chore: additional data chore: add test delay for CI pre-commit fix for CI fix for CI

shon-button force-pushed the reporting_buttons_fixes branch from 076a829 to bd961e9 Compare December 12, 2024 00:21

fix for CI

9989a1f

shon-button merged commit 8b9bb06 into develop Dec 12, 2024
42 checks passed

shon-button deleted the reporting_buttons_fixes branch December 18, 2024 14:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

reporting buttons fixes #2567

reporting buttons fixes #2567

gdalcengio commented Dec 10, 2024 •

edited by shon-button

Loading

shon-button Dec 11, 2024 •

edited

Loading

shon-button commented Dec 11, 2024 •

edited

Loading

shon-button Dec 11, 2024

shon-button commented Dec 11, 2024 •

edited

Loading

shon-button commented Dec 11, 2024 •

edited

Loading

shon-button Dec 11, 2024

acatchpole left a comment

acatchpole Dec 12, 2024

shon-button commented Dec 12, 2024 •

edited

Loading

shon-button commented Dec 12, 2024

gdalcengio commented Dec 18, 2024

		@@ -236,8 +236,6 @@ export default function FacilityEmissionAllocationForm({
		setSubmitButtonDisabled(false);

reporting buttons fixes #2567

reporting buttons fixes #2567

Conversation

gdalcengio commented Dec 10, 2024 • edited by shon-button Loading

🔬 SH Post Review - Testing:

shon-button Dec 11, 2024 • edited Loading

Choose a reason for hiding this comment

shon-button commented Dec 11, 2024 • edited Loading

shon-button Dec 11, 2024

Choose a reason for hiding this comment

shon-button commented Dec 11, 2024 • edited Loading

shon-button commented Dec 11, 2024 • edited Loading

shon-button Dec 11, 2024

Choose a reason for hiding this comment

acatchpole left a comment

Choose a reason for hiding this comment

acatchpole Dec 12, 2024

Choose a reason for hiding this comment

shon-button commented Dec 12, 2024 • edited Loading

shon-button commented Dec 12, 2024

gdalcengio commented Dec 18, 2024

gdalcengio commented Dec 10, 2024 •

edited by shon-button

Loading

shon-button Dec 11, 2024 •

edited

Loading

shon-button commented Dec 11, 2024 •

edited

Loading

shon-button commented Dec 11, 2024 •

edited

Loading

shon-button commented Dec 11, 2024 •

edited

Loading

shon-button commented Dec 12, 2024 •

edited

Loading