Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report validation on submit: verification statement presence only in certain cases #450

Closed
1 of 18 tasks
pbastia opened this issue Dec 17, 2024 · 4 comments
Closed
1 of 18 tasks
Assignees
Labels
High Priority Needs AC Missing Acceptance Criteria User Story A User Story issue type

Comments

@pbastia
Copy link
Contributor

pbastia commented Dec 17, 2024

Description:

After #405 is completed, we can amend the verification statement validation to include the following rules:

Verification Page Requirement

  1. Registration Purpose: Users must complete the verification page if the registration purpose is any of the following:
  • OBPS Regulated Operation
  • Opt-in
  • New Entrants
  1. Emissions Threshold: Users must complete the verification page if:
  • The registration purpose is Reporting Operation, and
  • Total attributable emissions (as shown on the Emissions Summary page) are greater than or equal to 25,000 TCo₂e.

Acceptance Criteria:

Given
When
Then

Development Checklist:

  • In file bc_obps/reporting/service/report_submission_service.py refactor def validate_report to use verification statement is mandatory logic in service ReportVerificationService.get_report_needs_verification(version_id)
  • Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

  • User story is included
  • User role and type are identified
  • Acceptance criteria are included
  • Wireframes are included (if required)
  • Design / Solution is accepted by Product Owner
  • Dependencies are identified (technical, business, regulatory/policy)
  • Story has been estimated (under 13 pts)

Definition of Done (Note: If any of these points are not applicable, mark N/A)

  • Acceptance criteria are tested by the CI pipeline
  • UI meets accessibility requirements
  • Configuration changes are documented, documentation and designs are updated
  • Passes code peer-review
  • Passes QA of Acceptance Criteria with verification in Dev and Test
  • Ticket is ready to be merged to main branch
  • Can be demoed in Sprint Review
  • Bugs or future work cards are identified and created
  • Reviewed and approved by Product Owner

Blocked By/Blocking

Notes:

@rdromey
Copy link
Contributor

rdromey commented Dec 18, 2024

@shon to write AC+Dev Checklist

@shon-button shon-button removed Backlog Refinement Tickets that require further refinement Blocked This ticket is blocked by another ticket. labels Dec 19, 2024
@shon-button shon-button self-assigned this Dec 19, 2024
@shon-button
Copy link

@patriciarussellCAS

This should be tested with release v1.18.0 - after the refactor of conditions for when to display or not addressed in PR 2625

PR Test Steps
Replace http://localhost:3000/ with https://cas-bciers-frontend-dev.apps.silver.devops.gov.bc.ca/

@rdromey rdromey added this to the Enter verification information milestone Jan 7, 2025
@fviduya
Copy link

fviduya commented Jan 15, 2025

This doesn't have an Acceptance Criteria yet, but I've tested what's on the description:

I have tested this in the DEV environment, here's the test document for reference.

I have verified that Verification page is displayed on the task list under Sign-off & Submit only when:

Registration Purpose = OBPS Regulated Operation, New Entrant, Opted-In, Reporting Operation (Total attributable emissions >= 25,000 tc02e)

I was not able to test the condition where Registration Purpose = Reporting Operation and total Emission Summary >= 25,000 tc02e due to issue with getting into Emission Summary page

I also tested some scenarios where Verification page should not be visible:

Registration Purpose = Potential Reporting Operation - RESULT: Verification not showing on the task list, however, if you click Back button twice it will show the page itself, breadcrumbs also show Verification. Please check page 7 of the attached document.
^ Same as above for Registration Purpose = Reporting Operation < 25,000 tc02e

cc: @vesselak / @patriciarussellCAS

@patriciarussellCAS
Copy link

Thanks for the review. I have created ticket #505 to address the issue flagged here. otherwise this is working as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority Needs AC Missing Acceptance Criteria User Story A User Story issue type
Projects
None yet
Development

No branches or pull requests

6 participants