-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] Update imports to not import from common package root #3345
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Yeah, I've been trying to clean these up when I come accross them, but it's nice to get more of them at once!
Nice. How do you feel about either removing or disabling the |
93bc9cd
c28fc97
to
93bc9cd
Compare
93bc9cd
to
23dfbe0
Compare
Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'Issues Measures |
Quality Gate failed for 'bcgov-sonarcloud_mds_common'Failed conditions |
Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'Failed conditions |
@matbusby-fw @taraepp Updated this to deal with the rest of the imports. Also nuked the exports in Agreed that it would be nice to get rid of the common package check. I updated it to ignore whitespace changes to make it a bit less intrusive, but think we should hold off removing it until all the TSF components are out of there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this file simply be deleted?
Objective
MDS-CHORE
The "@mds/common" namespace is polluted with a lot of exports. Some of these have naming collisions that in some cases might cause unforeseen bugs.
This PR updates a fair few imports to be more specific with the goal of eventually get rid of those warnings, which in turn will unblock further improvements such as the use of rspack.
Note: There's still a lot of imports left to fix, but gotta start somewhere