Skip to content

Commit

Permalink
- app version = 5.2.14
Browse files Browse the repository at this point in the history
- updated "not restorable" error text (per Janis)
- added missing mapping to isChangeNameXpro()
- added missing mapping to isSelectedXproAndRestorable()
  • Loading branch information
severinbeauvais committed Oct 19, 2023
1 parent c502793 commit 52cf354
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "name-request",
"version": "5.2.13",
"version": "5.2.14",
"private": true,
"appName": "Name Request UI",
"sbcName": "SBC Common Components",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export default class BusinessLookupFetch extends Mixins(CommonMixin, SearchMixin
if (this.isConversion) {
return this.isAlterable || 'This business cannot alter their business type'
} else if (this.isRestoration) {
return this.isRestorable || 'This business cannot be restored'
return this.isRestorable || 'This business cannot be reactivated'
} else if (this.isChangeName) {
return this.isNameChangeable || 'This business cannot change their business name'
}
Expand Down
6 changes: 4 additions & 2 deletions src/mixins/search-mixin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@ export class SearchMixin extends Mixins(CommonMixin) {
}

get isChangeNameXpro (): boolean {
return XproMapping.CHG.includes(this.getSearchBusiness?.legalType)
const corpType = this.getSearchBusiness?.legalType as unknown as CorpTypeCd
return XproMapping.CHG.includes(this.corpTypeToEntityType(corpType))
}

/** Whether company can change name. */
Expand All @@ -172,7 +173,8 @@ export class SearchMixin extends Mixins(CommonMixin) {

/** Whether the selected XPRO is restorable. */
get isSelectedXproAndRestorable (): boolean {
return XproMapping.REH.includes(this.getSearchBusiness?.legalType)
const corpType = this.getSearchBusiness?.legalType as unknown as CorpTypeCd
return XproMapping.REH.includes(this.corpTypeToEntityType(corpType))
}

/** Whether the selected business' legal type is BC and restorable. */
Expand Down

0 comments on commit 52cf354

Please sign in to comment.