Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

18299 fix xpro A -> XCR mapping (#736) #737

Closed
wants to merge 1 commit into from
Closed

18299 fix xpro A -> XCR mapping (#736) #737

wants to merge 1 commit into from

Conversation

severinbeauvais
Copy link
Collaborator

@severinbeauvais severinbeauvais commented Oct 24, 2023 •
edited
Loading

This PR is obsolete.

Issue #: /bcgov/entity###

Description of changes:

  • app version = 5.2.14.a
  • fixed Xpro REH and CHG mapping: XUL should be XCR
  • fixed entity type to corp type mapping: removed entity type A, XCR should map to EXTRA_PRO_A and XUL should map to XPRO_UNLIMITED_LIABILITY_COMPANY
  • fixed corp type to entity type mapping: EXTRA_PRO_A should map to XCR and XPRO_UNLIMITED_LIABILITY_COMPANY should map to XUL

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

@severinbeauvais
18299 fix xpro A -> XCR mapping (#736)
16623ba 
* - app version = 5.2.14.a

* - fixed Xpro REH and CHG mapping: XUL should be XCR
- fixed entity type to corp type mapping: removed entity type A, XCR should map to EXTRA_PRO_A and XUL should map to XPRO_UNLIMITED_LIABILITY_COMPANY
- fixed corp type to entity type mapping: EXTRA_PRO_A should map to XCR and XPRO_UNLIMITED_LIABILITY_COMPANY should map to XUL
@severinbeauvais severinbeauvais self-assigned this Oct 24, 2023
@severinbeauvais severinbeauvais temporarily deployed to prod October 24, 2023 20:31 — with GitHub Actions Inactive
@severinbeauvais severinbeauvais temporarily deployed to dev October 24, 2023 21:00 — with GitHub Actions Inactive
@ozamani9gh ozamani9gh temporarily deployed to test October 24, 2023 21:10 — with GitHub Actions Inactive
@ozamani9gh ozamani9gh temporarily deployed to prod October 24, 2023 21:15 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eve-git eve-git Awaiting requested review from eve-git eve-git will be requested when the pull request is marked ready for review eve-git is a code owner

@shaangill025 shaangill025 Awaiting requested review from shaangill025 shaangill025 will be requested when the pull request is marked ready for review shaangill025 is a code owner

@stevenc987 stevenc987 Awaiting requested review from stevenc987 stevenc987 will be requested when the pull request is marked ready for review stevenc987 is a code owner

@mengdong19 mengdong19 Awaiting requested review from mengdong19 mengdong19 will be requested when the pull request is marked ready for review mengdong19 is a code owner

@ozamani9gh ozamani9gh Awaiting requested review from ozamani9gh ozamani9gh will be requested when the pull request is marked ready for review ozamani9gh is a code owner

@rarmitag rarmitag Awaiting requested review from rarmitag rarmitag will be requested when the pull request is marked ready for review rarmitag is a code owner

@flutistar flutistar Awaiting requested review from flutistar flutistar will be requested when the pull request is marked ready for review flutistar is a code owner

@EPortman EPortman Awaiting requested review from EPortman EPortman will be requested when the pull request is marked ready for review EPortman is a code owner

Assignees

@severinbeauvais severinbeauvais

Labels
Do Not Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@severinbeauvais @pwei1018 @ozamani9gh