Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18299 fix xpro A -> XCR mapping (#736) #737

Closed
wants to merge 1 commit into from
Closed

18299 fix xpro A -> XCR mapping (#736) #737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "name-request",
"version": "5.2.14",
"version": "5.2.14a",
"private": true,
"appName": "Name Request UI",
"sbcName": "SBC Common Components",
Expand Down
8 changes: 4 additions & 4 deletions src/list-data/request-action-mapping.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,16 +76,16 @@ export const XproMapping: RequestActionMappingI = {
REH: [
EntityTypes.RLC, // maps to Corp Type "LLC"
EntityTypes.XCP, // maps to Corp Type "XCP"
EntityTypes.XSO, // maps to Corp Type "XS"
EntityTypes.XUL // maps to Corp Type "A"
EntityTypes.XCR, // maps to Corp Type "EXTRA_PRO_A"
EntityTypes.XSO // maps to Corp Type "XS"
],
CHG: [
EntityTypes.RLC, // maps to Corp Type "LLC"
EntityTypes.XCP, // maps to Corp Type "XCP"
EntityTypes.XCR, // maps to Corp Type "EXTRA_PRO_A"
EntityTypes.XLL, // maps to Corp Type "XL"
EntityTypes.XLP, // maps to Corp Type "XP"
EntityTypes.XSO, // maps to Corp Type "XS"
EntityTypes.XUL // maps to Corp Type "A"
EntityTypes.XSO // maps to Corp Type "XS"
]
}

Expand Down
18 changes: 9 additions & 9 deletions src/mixins/common-mixin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ export class CommonMixin extends Vue {
*/
entityTypeToCorpType (entityType: EntityTypes): CorpTypeCd {
switch (entityType) {
case EntityTypes.A: return CorpTypeCd.EXTRA_PRO_A // same as XUL
case EntityTypes.BC: return CorpTypeCd.BENEFIT_COMPANY
case EntityTypes.CC: return CorpTypeCd.BC_CCC
case EntityTypes.CP: return CorpTypeCd.COOP
Expand All @@ -77,13 +76,13 @@ export class CommonMixin extends Vue {
case EntityTypes.SO: return CorpTypeCd.SOCIETY
case EntityTypes.UL: return CorpTypeCd.BC_ULC_COMPANY
case EntityTypes.XCP: return CorpTypeCd.XPRO_COOP
case EntityTypes.XCR: return CorpTypeCd.XPRO_CORPORATION
case EntityTypes.XCR: return CorpTypeCd.EXTRA_PRO_A
case EntityTypes.XL: return CorpTypeCd.XPRO_LL_PARTNR // same as XLL
case EntityTypes.XLL: return CorpTypeCd.XPRO_LL_PARTNR
case EntityTypes.XLP: return CorpTypeCd.XPRO_LIM_PARTNR
case EntityTypes.XP: return CorpTypeCd.XPRO_LIM_PARTNR // same as XLP
case EntityTypes.XSO: return CorpTypeCd.XPRO_SOCIETY
case EntityTypes.XUL: return CorpTypeCd.EXTRA_PRO_A
case EntityTypes.XUL: return CorpTypeCd.XPRO_UNLIMITED_LIABILITY_COMPANY
default: return null
}
}
Expand All @@ -99,7 +98,7 @@ export class CommonMixin extends Vue {
case CorpTypeCd.BC_COMPANY: return EntityTypes.CR
case CorpTypeCd.BC_ULC_COMPANY: return EntityTypes.UL
case CorpTypeCd.COOP: return EntityTypes.CP
case CorpTypeCd.EXTRA_PRO_A: return EntityTypes.XUL
case CorpTypeCd.EXTRA_PRO_A: return EntityTypes.XCR
case CorpTypeCd.FINANCIAL: return EntityTypes.FI
case CorpTypeCd.PARTNERSHIP: return EntityTypes.GP
case CorpTypeCd.LIMITED_CO: return EntityTypes.RLC
Expand All @@ -114,6 +113,7 @@ export class CommonMixin extends Vue {
case CorpTypeCd.XPRO_LIM_PARTNR: return EntityTypes.XLP
case CorpTypeCd.XPRO_LL_PARTNR: return EntityTypes.XLL
case CorpTypeCd.XPRO_SOCIETY: return EntityTypes.XSO
case CorpTypeCd.XPRO_UNLIMITED_LIABILITY_COMPANY: return EntityTypes.XUL
default: return null
}
}
Expand Down Expand Up @@ -212,13 +212,13 @@ export class CommonMixin extends Vue {
/** Returns true if the specified entity type is for an Extraprovincial Company. */
isXproEntityType (type: EntityTypes): boolean {
return [
EntityTypes.XCR,
EntityTypes.XUL,
EntityTypes.RLC,
EntityTypes.XLP,
EntityTypes.XLL,
EntityTypes.XCP,
EntityTypes.XSO
EntityTypes.XCR,
EntityTypes.XLL,
EntityTypes.XLP,
EntityTypes.XSO,
EntityTypes.XUL
].includes(type)
}

Expand Down