20951 Added support for continuation in entity types #761
Conversation
|
/gcbrun |
severinbeauvais
requested review from
eve-git,
jamespaologarcia,
ozamani9gh and
JazzarKarim
|
Temporary Url for review: https://namerequest-dev--pr-761-38upl0oq.web.app |
| @@ -176,7 +176,7 @@ export default class App extends Mixins( | |||
| @Getter isAuthenticated!: boolean | |||
| @Getter isRoleStaff!: boolean | |||
| @Getter isMobile!: boolean | |||
| @Getter isNewBusiness!: boolean | |||
| // @Getter isNewBusiness!: boolean | |||
There was a problem hiding this comment.
This getter is already imported via a mixin so declaring it here displays an error in VS Code. However, I like to keep the declaration here so that it's explicit that this code file uses this getter.
| case EntityTypes.C: return 'Continuation In (BC Limited Company)' | ||
| case EntityTypes.CBEN: return 'Continuation In (Benefit Company)' | ||
| case EntityTypes.CCC: return 'Continuation In (BC Community Contribution Company)' | ||
| case EntityTypes.CUL: return 'Continuation In (BC Unlimited Liability Company)' |
There was a problem hiding this comment.
To be honest, I think these cases don't get used, because as far as Namerequest UI is concerned, the subject NR is for a "BC Benefit Company" (for example), not a CBEN. I think only LEAR cares that this is a continued in benefit company.
There was a problem hiding this comment.
PS - I have asked Naveen to confirm with the business that the NR should appear as a "BC Benefit Company" (as per the screenshot below) even though, internally, LEAR knows it as a CBEN. We will have an answer tomorrow.
| case EntityTypes.CP: return CorpTypeCd.COOP | ||
| case EntityTypes.CR: return CorpTypeCd.BC_COMPANY | ||
| case EntityTypes.CUL: return CorpTypeCd.ULC_CONTINUE_IN |
There was a problem hiding this comment.
Same comment as above: I think these (and the 4 below) aren't used, but I added them for completeness.
|
Here's what a continuation in NR for a BC Benefit Company looks like:
Note that the entity type code (that Namerequest UI uses) is BC (Benefit Company), and the request action code is MVE (move aka continue in). NameX API filled in legal type (CBEN) and request type code (BECT):
|
- added CBEN entity type - added string/type conversions to common mixin
Issue #: bcgov/entity#20951
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).