Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20951 Added support for continuation in entity types #761

Merged
merged 2 commits into from
Apr 22, 2024
Merged

20951 Added support for continuation in entity types #761

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b75207d
- app version = 5.4.7
Apr 22, 2024
0168112
- updated comment
Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "name-request",
"version": "5.4.6",
"version": "5.4.7",
"private": true,
"appName": "Name Request UI",
"sbcName": "SBC Common Components",
Expand Down
2 changes: 1 addition & 1 deletion src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ export default class App extends Mixins(
@Getter isAuthenticated!: boolean
@Getter isRoleStaff!: boolean
@Getter isMobile!: boolean
@Getter isNewBusiness!: boolean
// @Getter isNewBusiness!: boolean
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This getter is already imported via a mixin so declaring it here displays an error in VS Code. However, I like to keep the declaration here so that it's explicit that this code file uses this getter.


// Global actions
@Action resetAnalyzeName!: ActionBindingIF
Expand Down
1 change: 1 addition & 0 deletions src/enums/entity-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ export enum EntityTypes {
BC = CorpTypeCd.BC_COMPANY,
BEN = CorpTypeCd.BENEFIT_COMPANY,
C = CorpTypeCd.CONTINUE_IN,
CBEN = CorpTypeCd.BEN_CONTINUE_IN,
CC = CorpTypeCd.BC_CCC,
CCC = CorpTypeCd.CCC_CONTINUE_IN,
CP = CorpTypeCd.COOP,
Expand Down
8 changes: 4 additions & 4 deletions src/list-data/request-action-mapping.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ export const BcMapping: RequestActionMappingI = {
// every entity type except Parishes and Private Act
CHG: EntityTypesBC.filter(ent => ent !== EntityTypes.PAR && ent !== EntityTypes.PA),
MVE: [
EntityTypes.CR,
EntityTypes.CC,
EntityTypes.CR, // will become CorpTypeCd.CONTINUE_IN
JazzarKarim marked this conversation as resolved.
Show resolved Hide resolved
EntityTypes.CC, // will become CorpTypeCd.CCC_CONTINUE_IN
EntityTypes.CP,
EntityTypes.UL,
EntityTypes.UL, // will become CorpTypeCd.ULC_CONTINUE_IN
EntityTypes.SO,
EntityTypes.BC
EntityTypes.BC // will become CorpTypeCd.BEN_CONTINUE_IN
]
}

Expand Down
14 changes: 14 additions & 0 deletions src/mixins/common-mixin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ export class CommonMixin extends Vue {
case EntityTypes.SP: return 'BC Sole Proprietorship'
case EntityTypes.UL: return 'BC Unlimited Liability Company'

// Continuation In Entity Types:
case EntityTypes.C: return 'Continuation In (BC Limited Company)'
case EntityTypes.CBEN: return 'Continuation In (Benefit Company)'
case EntityTypes.CCC: return 'Continuation In (BC Community Contribution Company)'
case EntityTypes.CUL: return 'Continuation In (BC Unlimited Liability Company)'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I think these cases don't get used, because as far as Namerequest UI is concerned, the subject NR is for a "BC Benefit Company" (for example), not a CBEN. I think only LEAR cares that this is a continued in benefit company.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS - I have asked Naveen to confirm with the business that the NR should appear as a "BC Benefit Company" (as per the screenshot below) even though, internally, LEAR knows it as a CBEN. We will have an answer tomorrow.


// XPRO Entity Types:
case EntityTypes.XCR: return 'Extraprovincial Limited Company'
case EntityTypes.XUL: return 'Extraprovincial Unlimited Liability Company'
Expand All @@ -60,9 +66,13 @@ export class CommonMixin extends Vue {
entityTypeToCorpType (entityType: EntityTypes): CorpTypeCd {
switch (entityType) {
case EntityTypes.BC: return CorpTypeCd.BENEFIT_COMPANY
case EntityTypes.C: return CorpTypeCd.CONTINUE_IN
case EntityTypes.CBEN: return CorpTypeCd.BEN_CONTINUE_IN
case EntityTypes.CC: return CorpTypeCd.BC_CCC
case EntityTypes.CCC: return CorpTypeCd.CCC_CONTINUE_IN
case EntityTypes.CP: return CorpTypeCd.COOP
case EntityTypes.CR: return CorpTypeCd.BC_COMPANY
case EntityTypes.CUL: return CorpTypeCd.ULC_CONTINUE_IN
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above: I think these (and the 4 below) aren't used, but I added them for completeness.

case EntityTypes.DBA: return CorpTypeCd.SOLE_PROP // same as FR
case EntityTypes.FI: return CorpTypeCd.FINANCIAL
case EntityTypes.FR: return CorpTypeCd.SOLE_PROP
Expand Down Expand Up @@ -93,11 +103,14 @@ export class CommonMixin extends Vue {
*/
corpTypeToEntityType (entityType: CorpTypeCd): EntityTypes {
switch (entityType) {
case CorpTypeCd.BEN_CONTINUE_IN: return EntityTypes.CBEN
case CorpTypeCd.BENEFIT_COMPANY: return EntityTypes.BC
case CorpTypeCd.BC_CCC: return EntityTypes.CC
case CorpTypeCd.BC_COMPANY: return EntityTypes.CR
case CorpTypeCd.BC_ULC_COMPANY: return EntityTypes.UL
case CorpTypeCd.CCC_CONTINUE_IN: return EntityTypes.CCC
case CorpTypeCd.COOP: return EntityTypes.CP
case CorpTypeCd.CONTINUE_IN: return EntityTypes.C
case CorpTypeCd.EXTRA_PRO_A: return EntityTypes.XCR
case CorpTypeCd.FINANCIAL: return EntityTypes.FI
case CorpTypeCd.PARTNERSHIP: return EntityTypes.GP
Expand All @@ -108,6 +121,7 @@ export class CommonMixin extends Vue {
case CorpTypeCd.PARISHES: return EntityTypes.PAR
case CorpTypeCd.SOCIETY: return EntityTypes.SO
case CorpTypeCd.SOLE_PROP: return EntityTypes.FR
case CorpTypeCd.ULC_CONTINUE_IN: return EntityTypes.CUL
case CorpTypeCd.XPRO_COOP: return EntityTypes.XCP
case CorpTypeCd.XPRO_CORPORATION: return EntityTypes.XCR
case CorpTypeCd.XPRO_LIM_PARTNR: return EntityTypes.XLP
Expand Down
Loading