Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve initialization order issue #88

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Resolve initialization order issue #88

merged 1 commit into from
Jun 5, 2024

Conversation

kyle1morel
Copy link
Collaborator

Description

Resolve an initialization order issue in the StartView.

04d376c Resolve initialization order issue

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@kyle1morel kyle1morel requested a review from wilwong89 as a code owner June 5, 2024 19:01
@kyle1morel kyle1morel requested review from sanjaytkbabu and wilwong89 and removed request for wilwong89 June 5, 2024 19:02
Copy link

github-actions bot commented Jun 5, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 22.48% ( 533 / 2371 )
Methods: 20.09% ( 90 / 448 )
Lines: 25.48% ( 329 / 1291 )
Branches: 18.04% ( 114 / 632 )

Copy link

github-actions bot commented Jun 5, 2024

Coverage Report (Application)

Totals Coverage
Statements: 47.09% ( 542 / 1151 )
Methods: 37.44% ( 85 / 227 )
Lines: 60.03% ( 365 / 608 )
Branches: 29.11% ( 92 / 316 )

Copy link

codeclimate bot commented Jun 5, 2024

Code Climate has analyzed commit 04d376c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 36.5% (0.0% change).

View more on Code Climate.

@kyle1morel kyle1morel merged commit 7b06e47 into master Jun 5, 2024
21 of 22 checks passed
@kyle1morel kyle1morel deleted the bug/start-view branch June 5, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants