Hide zero amount for binance #35
Conversation
…n#30) * Use abstract wallet and constructor * Remove unsed promiseutils
|
I'm actually not sure if we should do this, in this manner... Right now I intended to add all coins that are coming from the exchanges, for the purpose of keeping track where to buy them, even if you hold 0. |
|
I'm not sure, but Binance lists ALL the coins in the exchange. I just used 2 coins in binance bit it adds a lot more. |
|
Thanks for this quick fix. I ran into this because even though I had set Edit: This is not how it should be fixed though. Poloniex also displays empty bags. Opened #38 |
|
If Poloniex also does that, shouldn't we also filter that? |
|
Yes, but I don't think it should be an exchange specific fix. It's OK to parse these empty bags (for example so that you at least know what coins are available on the exchange), it is just a matter of not displaying them. Like I state in #38, coins with a value anywhere between 0 and |
|
Yes, both of you are correct. I think we should address this at a higher level. I suggest we create something like a Strategy class, that abstracts the different portfolio strategies... Examples could be |
benmarten
force-pushed
the
develop
branch
2 times, most recently
from
ef42ccf
to
d5ab3e7
Compare
|
Yes this is a logical next step! And perfect solution to this issue. Right now the only strategy known is to allocate based on market cap. Of course it will show you a lot of empty coins because your allocation of 0 is not enough and you need to buy in order to reflect market cap. How I solve this when manually setting allocation is by not adding coins to the portfolio that have an allocation of 0 ( Your strategy class sounds like a great formal way of dealing with this mess and I would love to see and work with your proposal. |
Re-do #32 against correct branch.