Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.0/cleanup lifecycles #385

Closed
wants to merge 11 commits into from
Closed

5.0/cleanup lifecycles #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b4531d6
Fix typo of "nonexistent"
sunnavy Jul 21, 2021
f7b3dc7
Clean up lifecycles on save when possible
sunnavy Jul 21, 2021
aa4426a
Trim any leading and trailing spaces from name on lifecycle create
sunnavy Jan 31, 2024
dbfa304
Do not merge old values for hash configs in database
sunnavy Feb 1, 2024
9fa6147
Support to delete lifecycles
sunnavy Feb 1, 2024
da83732
Test lifecycle deletions
sunnavy Feb 5, 2024
d2543f3
Show lifecycle warnings to admins who are accessing lifecycle pages
sunnavy Feb 2, 2024
04b1c87
Add protective code in case of invalid lifecycles
sunnavy Feb 5, 2024
7292690
Test lifecycle warnings on admin web UI
sunnavy Feb 5, 2024
3679823
Support to update maps of a lifecycle via JSON on Advanced page
sunnavy Feb 2, 2024
500d385
Add links to help map statuses that have the same name
sunnavy Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/RT/Config.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3077,10 +3077,9 @@ sub LoadConfigFromDatabase {
: $type eq 'HASH' ? [ %$value ]
: [ $value ];

# hashes combine, but by default previous config settings shadow
# later changes, here we want database configs to shadow file ones.
# Unlike hashes in files that merge together, database configs are supposed to contain all the data, so no need
# to merge file configs. With it, admins are able to delete keys.
if ($type eq 'HASH') {
$val = [ $self->Get($name), @$val ];
$self->Set($name, ());
}

Expand Down
Loading
Loading