5.0/cleanup lifecycles #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here we just clean up obvious errors like nonexistent lifecycles, statuses, etc. This is initially to sync __maps__ when statuses are deleted from lifecycles.
This is initially to fix broken lifecycle links because the URL with Name=... doesn't retain the trailing space.
When admins update configs from web UI, the default values of inputs fully contain current config values, so there is no need to merge old values after update. By not merging old values, admins now are able to delete keys from hash configs. This is initially to support lifecycle deletions.
This gives admins hints of the issue of %Lifecycles configuration.
This is initially to get rid of server errors for our tests that contain other unsupported types(e.g. "racecar" type in "t/lifecycles/utils.pl").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.