Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0/cleanup lifecycles #386

Merged
merged 11 commits into from
Mar 27, 2024
Merged

5.0/cleanup lifecycles #386

merged 11 commits into from
Mar 27, 2024

Commits on Jan 31, 2024

  1. Fix typo of "nonexistent"

    sunnavy committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    b4531d6 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Clean up lifecycles on save when possible

    Here we just clean up obvious errors like nonexistent lifecycles,
    statuses, etc. This is initially to sync __maps__ when statuses are
    deleted from lifecycles.
    sunnavy committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    9cdf371 View commit details
    Browse the repository at this point in the history
  2. Trim any leading and trailing spaces from name on lifecycle create

    This is initially to fix broken lifecycle links because the URL with
    Name=... doesn't retain the trailing space.
    sunnavy committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    4f0700d View commit details
    Browse the repository at this point in the history
  3. Do not merge old values for hash configs in database

    When admins update configs from web UI, the default values of inputs fully
    contain current config values, so there is no need to merge old values after
    update. By not merging old values, admins now are able to delete keys from
    hash configs.
    
    This is initially to support lifecycle deletions.
    sunnavy committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    ce3adb0 View commit details
    Browse the repository at this point in the history
  4. Support to delete lifecycles

    sunnavy committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    e19e055 View commit details
    Browse the repository at this point in the history
  5. Test lifecycle deletions

    sunnavy committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    ae7daec View commit details
    Browse the repository at this point in the history
  6. Show lifecycle warnings to admins who are accessing lifecycle pages

    This gives admins hints of the issue of %Lifecycles configuration.
    sunnavy committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    302af2a View commit details
    Browse the repository at this point in the history
  7. Add protective code in case of invalid lifecycles

    This is initially to get rid of server errors for our tests that contain
    other unsupported types(e.g. "racecar" type in "t/lifecycles/utils.pl").
    sunnavy committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    24342d3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1753c63 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3e9651f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    169ea4a View commit details
    Browse the repository at this point in the history