Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature gate picking backends. #15306

Closed
brandon-reinhart opened this issue Sep 19, 2024 · 1 comment · Fixed by #15369
Closed

Feature gate picking backends. #15306

brandon-reinhart opened this issue Sep 19, 2024 · 1 comment · Fixed by #15369
Labels
A-Picking Pointing at and selecting objects of all sorts C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Milestone
0.15

Comments

@brandon-reinhart
Copy link
Contributor

brandon-reinhart commented Sep 19, 2024 •
edited
Loading

What problem does this solve or what need does it fill?

A user may want to turn on picking, but disable specific picking back ends. In my case, I'd rather turn off sprite picking and use a custom, fine-grained bounding box picking backend instead. At the moment there is no way to opt-in to picking but opt-out of particular backends.

What solution would you like?

Features seem like the right way to do this.

What alternative(s) have you considered?

Could use a configuration resource or something, but that seems excessive. Most users probably don't need runtime configuration of picking?
@brandon-reinhart brandon-reinhart added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Sep 19, 2024
@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples A-Picking Pointing at and selecting objects of all sorts and removed C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Sep 19, 2024
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Sep 19, 2024
@BenjaminBrienen
Copy link
Contributor

I'm trying this now

@BenjaminBrienen BenjaminBrienen mentioned this issue Sep 22, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 22, 2024
@BenjaminBrienen
feature gate picking backends (#15369)
9386bd0 
# Objective

Fixes #15306

## Solution

- Add feature gate on the module and the place where each one is used
- Declare the features and make them default

## Testing

- CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Picking Pointing at and selecting objects of all sorts C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
0.15
Development

Successfully merging a pull request may close this issue.

feature gate picking backends BenjaminBrienen/bevy
3 participants
@alice-i-cecile @BenjaminBrienen @brandon-reinhart