Fixed no boot on TFT GD variants + cleanup #2885
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUGFIXES:
Bug was in
os_timer.c
. In particular:TIMER_INTF(TIMER6) &= ~TIMER_INTF_UPIF; // clear interrupt flag
was wrongly set to (see missing ~):
TIMER_INTF(TIMER6) &= TIMER_INTF_UPIF; // clear interrupt flag
Menu->Settings->Connection->Disconnect
button: bug was due to unallocated memory access. That bug was wrongly reported as already fixed by PR Serial bugfix on init/deinit #2822config.ini
: as reported in [BUG] BTT TFT35 E3 v3.0.1 #2884 the bug caused a random value forListening Mode
setting not provided inconfig.ini
. In general, a missing setting value inconfig.ini
caused a random value for the settingIMPROVEMENTS:
boot.h/c
andNumpad.h/c
. All credits to kisslorandTouchProcess
API: API renamed toTouch_Screen
and moved fromTFT\src\User\API\UI
toTFT\src\User\API
folder (that API is not a UI API). Furthermore, functions renamed appending prefixTS_
(common naming convention used for other core APIs).h
to.c
on some files (e.g.config
,boot
API) etc...NOTE: PR originally planned to be released after the merge of the remaining pending PRs (buzzer based on Interrupt, bugfix on Numpad and fw update from USB stick) as a final cleanup. Just anticipated to fix the issue on missing boot on TFT GD variants.
fixes #2884
PR STATE: Ready for merge