Skip to content

Commit

Permalink
fix gcc warning in NdFetchData
Browse files Browse the repository at this point in the history
this PR fixes this compiler warning: bddisasm_crt.c
bdx86_decoder.c
bdx86_decoder.c: In function ‘NdFetchData’:
bdx86_decoder.c:104:12: warning: operand of ‘?:’ changes signedness from ‘int’ to ‘long unsigned int’ due to unsignedness of other operand [-Wsign-compare]
  104 |            (2 == Size) ? ND_FETCH_16(Buffer) :
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  105 |            0;
      |            ~
bdx86_formatter.c
bdx86_helpers.c
Disasm library in ../bin/x64/Debug/libbddisasm.a
bddisasm_crt.c
bdx86_decoder.c
bdx86_decoder.c: In function ‘NdFetchData’:
bdx86_decoder.c:104:12: warning: operand of ‘?:’ changes signedness from ‘int’ to ‘long unsigned int’ due to unsignedness of other operand [-Wsign-compare]
  104 |            (2 == Size) ? ND_FETCH_16(Buffer) :
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  105 |            0;
      |            ~
bdx86_formatter.c
bdx86_helpers.c
Disasm library in ../bin/x64/Release/libbddisasm.a
bdshemu.c
bdshemu_x86.c
Shemu library in ../bin/x64/Debug/libbdshemu.a
bdshemu.c
bdshemu_x86.c
Shemu library in ../bin/x64/Release/libbdshemu.a
  • Loading branch information
BJNFNE committed Jul 30, 2024
1 parent 2b1c90b commit a631012
Showing 1 changed file with 13 additions and 6 deletions.
19 changes: 13 additions & 6 deletions bddisasm/bdx86_decoder.c
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ NdGetVersion(

}


//
// NdFetchData
//
Expand All @@ -98,11 +97,19 @@ NdFetchData(
ND_UINT8 Size
)
{
return (4 == Size) ? ND_FETCH_32(Buffer) :
(1 == Size) ? ND_FETCH_8(Buffer) :
(8 == Size) ? ND_FETCH_64(Buffer) :
(2 == Size) ? ND_FETCH_16(Buffer) :
0;
switch (Size)
{
case 1:
return ND_FETCH_8(Buffer);
case 2:
return ND_FETCH_16(Buffer);
case 4:
return ND_FETCH_32(Buffer);
case 8:
return ND_FETCH_64(Buffer);
default:
return 0;
}
}


Expand Down

0 comments on commit a631012

Please sign in to comment.