Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BWA-55] Add Long Press Menu to Search #194

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

brant-livefront
Copy link
Collaborator

@brant-livefront brant-livefront commented Nov 19, 2024

🎟️ Tracking

BWA-55

📔 Objective

This PR adds the long-press menu that's available on the Item List view to the Search view. It builds off of the changes introduced in the last PR and adds a few spots where we refresh the search list.

**Note: ** The screenshots have a very minor diff. The view is built in almost the exact same fashion as before and to the eye there's no difference. But looking in a diff, I see about 1px diff in the size of the TOTP expiring circle, which then ever so slightly makes the second row not as tall as before. This means there's about a 1px difference in where the text and globe icon rest in the third row. I replaced the screenshots because I think it's the same visually and still meets the designs, but I did want to call it out.

📸 Screenshots

Simulator Screenshot - iPhone 15 Pro - 2024-11-18 at 15 59 13

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Nov 19, 2024

Logo
Checkmarx One – Scan Summary & Details99b066d6-0837-45df-9dfe-da8dc79b3b92

No New Or Fixed Issues Found

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.79%. Comparing base (94fed8c) to head (90a8eb7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...UI/Vault/ItemList/ItemList/ItemListProcessor.swift 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   67.56%   67.79%   +0.22%     
==========================================
  Files         214      214              
  Lines        9568     9623      +55     
==========================================
+ Hits         6465     6524      +59     
+ Misses       3103     3099       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Base automatically changed from brant/BITAU-136-sync-failure-message to main November 21, 2024 21:47
@brant-livefront brant-livefront dismissed KatherineInCode’s stale review November 21, 2024 21:47

The base branch was changed.

@brant-livefront brant-livefront merged commit d0a2899 into main Nov 21, 2024
9 checks passed
@brant-livefront brant-livefront deleted the brant/BWA-55-add-long-press-menu-to-search branch November 21, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants