-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BWA-55] Add Long Press Menu to Search #194
[BWA-55] Add Long Press Menu to Search #194
Conversation
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
==========================================
+ Coverage 67.56% 67.79% +0.22%
==========================================
Files 214 214
Lines 9568 9623 +55
==========================================
+ Hits 6465 6524 +59
+ Misses 3103 3099 -4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
The base branch was changed.
🎟️ Tracking
BWA-55
📔 Objective
This PR adds the long-press menu that's available on the Item List view to the Search view. It builds off of the changes introduced in the last PR and adds a few spots where we refresh the search list.
**Note: ** The screenshots have a very minor diff. The view is built in almost the exact same fashion as before and to the eye there's no difference. But looking in a diff, I see about 1px diff in the size of the TOTP expiring circle, which then ever so slightly makes the second row not as tall as before. This means there's about a 1px difference in where the text and globe icon rest in the third row. I replaced the screenshots because I think it's the same visually and still meets the designs, but I did want to call it out.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes