[PM-15395] Update node commands for building non-chrome browser extensions #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying contributing-docs with
|
| Latest commit: |
4a2afc1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d48eab4a.contributing-docs.pages.dev |
| Branch Preview URL: | https://pm-15395.contributing-docs.pages.dev |
|
No New Or Fixed Issues Found |
jprusik
commented
Nov 25, 2024
Comment on lines
-200
to
-203
| 2. Edit `build/manifest.json`. Move the `nativeMessaging` permission from the `optional_permissions` | ||
| section into the `permissions` section | ||
| 3. Edit `build/popup/index.html`, replace `<html class="__BROWSER__">` to | ||
| `<html class="browser_safari">`. |
There was a problem hiding this comment.
These steps are already done by the build command
withinfocus
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-15395
📔 Objective
The contributing docs use outdated node commands to run builds for non-Chrome browsers
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes