Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15395] Update node commands for building non-chrome browser extensions #488

Merged
merged 2 commits into from
Nov 25, 2024
Merged

[PM-15395] Update node commands for building non-chrome browser extensions #488

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
520396a
update node commands for building non-chrome browser extensions
jprusik Nov 25, 2024
4a2afc1
remove unneeded instructions
jprusik Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions docs/getting-started/clients/browser/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ Before you start, you must complete the [Clients repository setup instructions](

The build commands use
[Manifest v3](https://developer.chrome.com/docs/extensions/develop/migrate/what-is-mv3) by
default. If you are building for Firefox or otherwise need a Manifest v2 build, you should use
the command `npm run build:watch:mv2` instead.
default. If you are building for a non-Chrome browser like Firefox or Safari, you should use the
command `npm run build:watch:<browser client name>` instead.

:::

Expand Down Expand Up @@ -194,15 +194,11 @@ The easiest way to develop the extension is to build and debug it using Xcode.
1. Build the extension:

```bash
npm run build:watch:mv2
npm run build:watch:safari
```

2. Edit `build/manifest.json`. Move the `nativeMessaging` permission from the `optional_permissions`
section into the `permissions` section
3. Edit `build/popup/index.html`, replace `<html class="__BROWSER__">` to
`<html class="browser_safari">`.
Comment on lines -200 to -203
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These steps are already done by the build command

4. Open `src/safari/desktop.xcodeproj` in Xcode
5. Run the "desktop" target.
2. Open `src/safari/desktop.xcodeproj` in Xcode
3. Run the "desktop" target.

:::note

Expand Down