Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub workflows for Windows #37

Merged
merged 9 commits into from
Nov 5, 2023

Commits on Oct 27, 2023

  1. build: add GitHub workflows for Windows

    - matrix: build against Qt 5 & 6
    stefanb2 committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    2350163 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2023

  1. Configuration menu
    Copy the full SHA
    3c28afc View commit details
    Browse the repository at this point in the history
  2. fix keypress_windows: use LPCWSTR (const wchar_t*) instead of LPCTSTR…

    … (const char*)
    
    fixes this error:
    D:\a\qMasterPassword\qMasterPassword\src\keypress_windows.cpp(99,5): error C2664: 'void CKeyboardSimulator::TextEntry(LPCTSTR)': cannot convert argument 1 from 'const _Elem *' to 'LPCTSTR' [D:\a\_temp\build\qMasterPassword.vcxproj]
    bkueng committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    9cf1ca6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f686648 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7b8bee8 View commit details
    Browse the repository at this point in the history
  5. fix: use _WIN32 instead of WIN32

    _WIN32 is defined by the compiler whereas WIN32 by the SDK.
    bkueng committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    61aa5b7 View commit details
    Browse the repository at this point in the history
  6. refactor logging: convert ELOG enum to an enum class & rename

    ERROR was conflicting with a macro on Windows.
    bkueng committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    8d90e04 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d91c48e View commit details
    Browse the repository at this point in the history
  8. build: use CXXFLAGS to add flags

    Setting CMAKE_CXX_FLAGS on the command line overrides the defaults
    generated by CMake, which leads to compiler warnings and broken code. We
    want to add flags to the compiler command line, hence setting CXXFLAGS
    environment variable is the correct approach.
    
    - CMakeLists.txt: prepend linker options to address linker warnings
    - fix some typos
    - reformat run parts to improve readability
    stefanb2 committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    da9be61 View commit details
    Browse the repository at this point in the history