Add GitHub workflows for Windows #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanb2
force-pushed
the
topic-add-github-workflows-for-windows
branch
4 times, most recently
from
4a74dac
to
04043c2
Compare
|
Ok, as expected: after merging the initial github workflow PR it is now possible to test CI changes with further PRs. |
|
@bkueng looks like Windows build no longer compiles and requires source code fixes. I'll leave this in draft for now. |
|
I can have a look myself. We can merge it as is if you like, and I'll do the follow-up. |
- matrix: build against Qt 5 & 6
stefanb2
force-pushed
the
topic-add-github-workflows-for-windows
branch
from
04043c2
to
2350163
Compare
… (const char*) fixes this error: D:\a\qMasterPassword\qMasterPassword\src\keypress_windows.cpp(99,5): error C2664: 'void CKeyboardSimulator::TextEntry(LPCTSTR)': cannot convert argument 1 from 'const _Elem *' to 'LPCTSTR' [D:\a\_temp\build\qMasterPassword.vcxproj]
_WIN32 is defined by the compiler whereas WIN32 by the SDK.
ERROR was conflicting with a macro on Windows.
stefanb2
force-pushed
the
topic-add-github-workflows-for-windows
branch
3 times, most recently
from
eda8e3d
to
308cdd5
Compare
Setting CMAKE_CXX_FLAGS on the command line overrides the defaults generated by CMake, which leads to compiler warnings and broken code. We want to add flags to the compiler command line, hence setting CXXFLAGS environment variable is the correct approach. - CMakeLists.txt: prepend linker options to address linker warnings - fix some typos - reformat run parts to improve readability
stefanb2
force-pushed
the
topic-add-github-workflows-for-windows
branch
from
308cdd5
to
da9be61
Compare
bkueng
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested.
I hope that after #36 has been merged that then workflow changes can be tested by pushing a PR.