build: add scrypt-windows as submodule

[stefanb2]

This is the simple approach: we know that the code from scrypt-windows repository compiles to a working static library on Windows.

• add git repository barrysteyn/scrypt-windows as submodule
• enable submodules checkout feature in Windows workflow
• convert the information from binding.gyp to a CMakeList.txt
• enable language C in project to enable CMake support for C modules
• add new directory src/3rdparty/scrypt to Windows build
• remove imported scrypt static library bits from Windows build
• remove scypt-windows steps from Windows workflow
• update build instructions accordingly
• README: add titles to links
• README: add status badge for GitHub actions

[stefanb2]

The --verbose finally revealed what is going on:

PreBuildEvent:
  Automatic MOC and UIC for target scrypt-windows
...
  "C:\Program Files\CMake\bin\cmake.exe" -E cmake_autogen D:/a/_temp/build/CMakeFiles/scrypt-windows_autogen.dir/AutogenInfo.json Debug
  if %errorlevel% neq 0 goto :cmEnd
  "C:\Program Files\CMake\bin\cmake.exe" -E touch D:/a/_temp/build/scrypt-windows_autogen/autouic_Debug.stamp
....
Lib:
  C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.37.32822\bin\HostX64\x64\Lib.exe /OUT:"D:\a\_temp\build\Debug\scrypt-windows.lib" /NOLOGO /MACHINE:X64  /machine:x64 "scrypt-windows.dir\Debug\mocs_compilation_Debug.obj"
  scrypt-windows.vcxproj -> D:\a\_temp\build\Debug\scrypt-windows.lib
...
Done Building Project "D:\a\_temp\build\scrypt-windows.vcxproj" (default targets).

So instead of compiling the source codes into the library, it creates 0 moc files and links those into the static library. No wonder why it looked like that the static library wasn't build at all...

[stefanb2]

OK, I give up for now. I'm either too dumb to understand cmake, or there is something fundamentally undocumented, f.ex. that add_library(STATIC) doesn't work for msbuild on Windows.

No matter how I slice or dice it, msbuild does not add the source files I added to the static library to the build. Hence the static library is always empty and the final binary link fails.

[stefanb2]

Doooooohhhhh if you add an existing source file to CMake project and CMake doesn't know what it is, it silently ignores it without any warnings. Very developer friendly behavior ☹️

[bkueng]

Doooooohhhhh if you add an existing source file to CMake project and CMake doesn't know what it is, it silently ignores it without any warnings. Very developer friendly behavior ☹️

Wow, indeed.