-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed missing datetime for timebased features and allowed warnings to be silenced #874
base: main
Are you sure you want to change the base?
fixed missing datetime for timebased features and allowed warnings to be silenced #874
Conversation
Codecov Report
@@ Coverage Diff @@
## main #874 +/- ##
==========================================
- Coverage 95.34% 95.19% -0.15%
==========================================
Files 18 18
Lines 1867 1872 +5
Branches 368 369 +1
==========================================
+ Hits 1780 1782 +2
- Misses 47 49 +2
- Partials 40 41 +1
Continue to review full report at Codecov.
|
fixed style issues |
Hi @Apsylem ! Sorry the review takes so long, I am a bit occupied in the moment. I will try to have a look in the next few days! |
Thanks @Apsylem - the changes look good to me. Could you include the current main branch? We have now added styling with black using a pre-commit hook. |
Sry, |
…b.com/Apsylem/tsfresh into dask_on_chunk_fix_and_warning_disable
Yeah, we very very recently introduced a separate way for the styling. If you want, I can take care of it (it is described in the newest version of the page you referring to, if you have a look into it on the repo directly) Update: sorry, my bad. I actually did not push the changes to the docs, so you couldn't know. Sorry about that! |
I have included the needed style changes to your branch :-) The information on how to run the pre-commit hooks (and the styling) is now also on our documentation page. One thing I noticed while doing the style fix: in your last commits you also included one commit from your other PR (the one which adds the While it is generally ok to have PRs which build on each other, please do not mix them and - if possible - please do never include multiple features in one PR. This makes the review very hard. In this case, please revert the changes for the If you need help in reverting the additional changes, please get in touch with me! Thanks. |
dask_feature_extraction_on_chunk did not forwardthe sort_by column as index to the time dependend feastures such al 'linear_trend_timewise. Also The option to forbid warnings has been added 'dask_feature_extraction_on_chunk'