-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@clack/prompts): adapt spinner
to CI environment
#169
Conversation
🦋 Changeset detectedLatest commit: 38c5371 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Suggestion: use something like https://www.npmjs.com/package/ci-info to cover more CI environments. |
5d9d06d
to
252de51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest that the new std-env dependency is removed as it probably isn't required. Generally, CI systems set CI=true, and I've yet to encounter one which doesn't.
If some random CI system doesn't set CI=true, then it's trivial for a user to just set it.
But in addition, if somebody wanted the old behaviour in CI, they could override it using this variable - whereas the std-env
library checks a whole pile of other variables, making that hard to do.
In addition,
Hey @antony, thanks for the review! I agree with the suggestions and have applied then to the PR, now we just check if CI variable is set to true. This way we cover most CI environments and still keep the bundle size small. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! This is great 💜
@natemoo-re when do you plan to release this fix? |
This PR addresses a issue reported in GitHub Actions where
spinner
was excessively writing messages, leading to confusion and cluttered output. To enhance the CI workflow and provide a smoother experience, the following changes have been made only for CI environment:spinner
method is called and the message updated, preventing unnecessary message repetition....
Demo
2023-09-22_17-06-00.mov
Closes #168