22041 when checking for "inconsistent interpolations" also check for "unrestored interpolations" #4
Conversation
There was a problem hiding this comment.
Looks good overall, just one minor comment about code style.
Additionally however, shouldn't we also include this check at translation time? I think this is explicitly where the 'raise_interpolation_error' function is for: To already raise these errors during translation, rather than in a check afterwards.
lib/i18n/tasks/interpolations.rb
Outdated
| locales.each do |locale| | ||
| data[locale].key_values.each do |key, value| | ||
| next unless value.is_a?(String) | ||
| next unless value.index('!!!!!') |
There was a problem hiding this comment.
Any reason not to use #include? ? It indicates the intent better I think
There was a problem hiding this comment.
@barak-neeman Can you add this change, before I do my next review?
There was a problem hiding this comment.
@barak-neeman Can you add this change, before I do my next review?
@tom-brouwer-bex my bad, I amended the commit without any changes... It's done now.
barak-neeman
force-pushed
the
22041-chore-final-round-of-fixing-i18n-interpolations
branch
from
198684c
to
3c278ec
Compare
Yes when the restoration is really bad, but that is rare and I don't really know how to detect a really bad restoration in code (no idea what they would look like). The usual restore failure would be DeepL gobbling one or two characters around the tags, and for those cases it's quite useful to let the translation finish. It's helpful for improving the restore_interpolations method, and it's helpful for manually fixing the translated text. The check here is just to prevent it from going into prod. |
…"unrestored interpolations" (which is just a fancy name for translation texts that have '!!!!!' in them - the new restore interpolations method outputs !!!!! when it fails to restore correctly) References bookingexperts/support#22041
barak-neeman
force-pushed
the
22041-chore-final-round-of-fixing-i18n-interpolations
branch
from
3c278ec
to
5279b0f
Compare
"unrestored interpolations" is just a fancy name for translation texts that have '!!!!!' in them - the new restore interpolations method outputs !!!!! when it fails to restore correctly
References bookingexperts/support#22041