Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metainfo: Make sure not to translate the app name #3333

Closed
wants to merge 2 commits into from

Conversation

ryonakano
Copy link
Contributor

Description

This simple string "Bottles" is used in different contexts:

  • as a generic noun; referring to wine prefixes
  • as a proper noun, referring to the app name

Make sure not to make the app name translatable since it's a proper noun.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Run meson setup builddir --prefix=/usr -Ddevel=true
  • Run ninja -C builddir
  • Run ninja -C builddir bottles-pot
  • Open po/bottles.pot and see the msgid "Bottles" does not have data/com.usebottles.bottles.metainfo.xml.in as its occurrence:
1767 #: bottles/frontend/ui/list.blp:42 bottles/frontend/windows/main_window.py:200
1768 msgid "Bottles"
1769 msgstr ""

Copy link

fab-sonarqube bot commented Apr 4, 2024

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Pylint result on modfied files:

Copy link

fab-sonarqube bot commented May 31, 2024

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ryonakano ryonakano closed this Aug 26, 2024
@ryonakano ryonakano deleted the no-translate-app-name branch August 26, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant