feat(smartNTT): process assets in new campaign array #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmartNTTs are targeted locally by the browser, and only shown to users if the configured conditions match. Non-smart capable browsers - that pre-date the introduction of this feature - should never show these NTTs. To enforce this: - the existing campaigns array in photo.json never includes smartNTTs - a new campaigns2 array is included in photo.json. This includes all NTTs, including smart ones. SmartNTT capable browsers read the campaigns2 array. Non-smart capable browsers continue to read the campaigns array. Assets referenced in either of these arrays need to be included within the crx package. See brave/ntp-si-assets#1192.
iambrianfung
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SmartNTTs are targeted locally by the browser, and only shown to users if the configured conditions match.
Non-smart capable browsers - that pre-date the introduction of this feature - should never show these NTTs. To enforce this:
SmartNTT capable browsers read the campaigns2 array. Non-smart capable browsers continue to read the campaigns array.
Assets referenced in either of these arrays need to be included within the crx package.
See https://github.com/brave/ntp-si-assets/pull/1192.