Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(smartNTT): process assets in new campaign array #998

Merged
merged 1 commit into from
Oct 17, 2024
Merged

feat(smartNTT): process assets in new campaign array #998

merged 1 commit into from
Oct 17, 2024

Commits on Oct 16, 2024

  1. feat(smartNTT): process assets in new campaign array 

    SmartNTTs are targeted locally by the browser, and only shown to users if the configured conditions match.

Non-smart capable browsers - that pre-date the introduction of this feature - should never show these NTTs. To enforce this:

- the existing campaigns array in photo.json never includes smartNTTs
- a new campaigns2 array is included in photo.json. This includes all NTTs, including smart ones.

SmartNTT capable browsers read the campaigns2 array. Non-smart capable browsers continue to read the campaigns array.

Assets referenced in either of these arrays need to be included within the crx package.

See brave/ntp-si-assets#1192.
    @tackley
    tackley committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    ccce547 View commit details
    Browse the repository at this point in the history