Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(breadbox): Addressing common portal error logs #154

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

snwessel
Copy link
Member

Fixing two errors that I noticed were appearing frequently in the portal error logs:

  1. FastAPI is occasionally throwing a validation error when trying to construct a task response (logs):
    {'type': 'int_from_float', 'loc': ('response', 'percentComplete'), 'msg': 'Input should be a valid integer, got a number with a fractional part', 'input': 0.03921781645880805}
    
  2. The public portal was running into a lot of 500 errors when trying to load the compound_sensitivity tile on the cell line page. This was happening about 2,000 times per day! (Logs here). I believe this was happening because we don't include drug screen data in the public release. This endpoint will now return a 404 error instead. The frontend is already catching these errors and defaults to hiding the tile when an error is thrown.

The 1st issue is the only one that might actually be creating problems for users, although custom analysis does seem to be working whenever I've tried it out (this issue might just be happening infrequently).

@snwessel snwessel changed the title Addressing common portal errors logs fix(breadbox): Addressing common portal error logs Dec 18, 2024
Copy link
Contributor

@jessica-cheng jessica-cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@snwessel snwessel merged commit c3efcc6 into master Dec 19, 2024
15 checks passed
snwessel added a commit that referenced this pull request Dec 19, 2024
Including fixing a difficult-to-recreate custom analysis bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants