Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functions to check struct and array missingness #738

Merged
merged 27 commits into from
Jan 23, 2025
Merged

Add functions to check struct and array missingness #738

merged 27 commits into from
Jan 23, 2025

Conversation

klaricch
Copy link
Contributor

No description provided.

@klaricch klaricch requested a review from matren395 November 25, 2024 15:19
@klaricch klaricch requested a review from ch-kr December 5, 2024 21:53
@klaricch klaricch removed the request for review from matren395 December 5, 2024 21:53
ch-kr
ch-kr previously requested changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@ch-kr ch-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few questions. could you also add tests for the new functions?

gnomad/assessment/validity_checks.py Outdated Show resolved Hide resolved
gnomad/assessment/validity_checks.py Outdated Show resolved Hide resolved
gnomad/assessment/validity_checks.py Outdated Show resolved Hide resolved
gnomad/assessment/validity_checks.py Show resolved Hide resolved
gnomad/assessment/validity_checks.py Outdated Show resolved Hide resolved
gnomad/assessment/validity_checks.py Outdated Show resolved Hide resolved
gnomad/assessment/validity_checks.py Outdated Show resolved Hide resolved
gnomad/assessment/validity_checks.py Show resolved Hide resolved
@klaricch klaricch requested a review from ch-kr December 9, 2024 18:42
ch-kr
ch-kr reviewed Dec 9, 2024
View reviewed changes
Copy link
Contributor

@ch-kr ch-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a question and a few more small suggestions. also reminder to add tests!

gnomad/assessment/validity_checks.py Show resolved Hide resolved
gnomad/assessment/validity_checks.py Outdated Show resolved Hide resolved
gnomad/assessment/validity_checks.py Show resolved Hide resolved
gnomad/assessment/validity_checks.py Outdated Show resolved Hide resolved
gnomad/assessment/validity_checks.py Outdated Show resolved Hide resolved
@klaricch klaricch requested a review from ch-kr December 11, 2024 21:51
@klaricch
Copy link
Contributor Author

will start adding tests

ch-kr
ch-kr reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@ch-kr ch-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small question -- thanks for working on the tests!

gnomad/assessment/validity_checks.py Show resolved Hide resolved
@klaricch klaricch requested a review from ch-kr December 17, 2024 17:29
ch-kr
ch-kr reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@ch-kr ch-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding tests! just a few small suggestions and questions

gnomad/assessment/validity_checks.py Show resolved Hide resolved
gnomad/assessment/validity_checks.py Outdated Show resolved Hide resolved
gnomad/assessment/validity_checks.py Outdated Show resolved Hide resolved
gnomad/assessment/validity_checks.py Outdated Show resolved Hide resolved
gnomad/assessment/validity_checks.py Outdated Show resolved Hide resolved
tests/assessment/test_validity_checks.py Show resolved Hide resolved
tests/assessment/test_validity_checks.py Outdated Show resolved Hide resolved
gnomad/assessment/validity_checks.py Show resolved Hide resolved
tests/assessment/test_validity_checks.py Outdated Show resolved Hide resolved
tests/assessment/test_validity_checks.py Outdated Show resolved Hide resolved
@mike-w-wilson mike-w-wilson self-assigned this Jan 16, 2025
mike-w-wilson
mike-w-wilson approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@mike-w-wilson mike-w-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good once types are added where they are missing. Thank you for adding the tests in! They all pass in my editor and give us some good coverage.

gnomad/assessment/validity_checks.py Outdated Show resolved Hide resolved
gnomad/assessment/validity_checks.py Outdated Show resolved Hide resolved
tests/assessment/test_validity_checks.py Outdated Show resolved Hide resolved
tests/assessment/test_validity_checks.py Outdated Show resolved Hide resolved
tests/assessment/test_validity_checks.py Outdated Show resolved Hide resolved
mike-w-wilson
mike-w-wilson approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@mike-w-wilson mike-w-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@klaricch klaricch dismissed ch-kr’s stale review January 23, 2025 16:29

changed reviewers

@klaricch klaricch merged commit 28a5433 into main Jan 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-w-wilson mike-w-wilson mike-w-wilson approved these changes

@ch-kr ch-kr Awaiting requested review from ch-kr

Assignees

@klaricch klaricch

@mike-w-wilson mike-w-wilson

Labels
Changelog: new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@klaricch @mike-w-wilson @ch-kr @matren395