Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coverage release global in GRCh37 #749

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Add coverage release global in GRCh37 #749

merged 2 commits into from
Jan 2, 2025

Conversation

KoalaQin
Copy link
Contributor

@KoalaQin KoalaQin commented Jan 2, 2025

This is to add the versions of released coverage HT as globals.

@KoalaQin KoalaQin self-assigned this Jan 2, 2025
@KoalaQin KoalaQin changed the title Add coverage release global in grch37 Add coverage release global in GRCh37 Jan 2, 2025
@KoalaQin KoalaQin requested review from jkgoodrich and ch-kr and removed request for jkgoodrich January 2, 2025 18:36
ch-kr
ch-kr requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@ch-kr ch-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this! only comment is to update the coverage function now that you've added these constants

@KoalaQin KoalaQin requested a review from ch-kr January 2, 2025 19:02
ch-kr
ch-kr approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@ch-kr ch-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KoalaQin KoalaQin merged commit a0f0f33 into main Jan 2, 2025
5 checks passed
@KoalaQin KoalaQin deleted the qh/coverage_global branch January 2, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch-kr ch-kr ch-kr approved these changes

Assignees

@ch-kr ch-kr

@KoalaQin KoalaQin

Labels
Changelog: ignore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KoalaQin @ch-kr