Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nanoid from 3.3.7 to 3.3.8 #2183

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 15, 2024

Bumps nanoid from 3.3.7 to 3.3.8.

Changelog

Sourced from nanoid's changelog.

3.3.8

  • Fixed a way to break Nano ID by passing non-integer size (by @​myndzi).
Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](ai/nanoid@3.3.7...3.3.8)

---
updated-dependencies:
- dependency-name: nanoid
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 15, 2024
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.12%. Comparing base (6a22526) to head (c29f6de).
Report is 22 commits behind head on development.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2183      +/-   ##
===============================================
- Coverage        70.15%   70.12%   -0.04%     
===============================================
  Files              332      332              
  Lines            28173    28173              
  Branches          2368     2368              
===============================================
- Hits             19764    19755       -9     
- Misses            8262     8271       +9     
  Partials           147      147              

see 4 files with indirect coverage changes

@eweitz eweitz self-requested a review December 17, 2024 16:46
@bistline bistline self-requested a review January 7, 2025 14:59
@eweitz
Copy link
Member

eweitz commented Jan 14, 2025

The build failure includes a false positive that we've seen before. The test_should_generate_pairwise_bucket_pathname failure also seems likely to be a false positive.

### FAILURES and ERRORS ###
*** Yarn test failures ***

*** Rails test failures ***

  DifferentialExpressionResultTest#test_should_generate_pairwise_bucket_pathname [/home/app/webapp/test/models/differential_expression_result_test.rb:141]:

  FireCloudClientTest#test_create_and_manage_workspace_entities:
  RuntimeError: Wrapped undumpable exception for: RestClient::InternalServerError: 500 Internal Server Error
Exiting with code: 1
Error: Process completed with exit code 1.

@eweitz eweitz added the build failure: false positive Build error confirmed as false positive. E.g. upstream service has a problem. label Jan 14, 2025
@eweitz eweitz merged commit 6aa7807 into development Jan 14, 2025
2 of 3 checks passed
@eweitz eweitz deleted the dependabot/npm_and_yarn/nanoid-3.3.8 branch January 14, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build failure: false positive Build error confirmed as false positive. E.g. upstream service has a problem. dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants