Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Add windows_latest to Github workflow matrix OS #354

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[FEAT] Add windows_latest to Github workflow matrix OS #354

wants to merge 8 commits into from

Conversation

jared-rimmer
Copy link
Member

Overview

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)

What does this solve?

Outstanding questions

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 13:41 — with GitHub Actions Error
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 13:41 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 13:41 — with GitHub Actions Error
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 13:45 — with GitHub Actions Error
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 13:45 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 13:45 — with GitHub Actions Error
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests June 2, 2023 13:45 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 13:45 — with GitHub Actions Failure
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests June 2, 2023 13:45 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 13:45 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 13:59 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 13:59 — with GitHub Actions Error
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 13:59 — with GitHub Actions Error
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 13:59 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 13:59 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 13:59 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 13:59 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 14:02 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 14:02 — with GitHub Actions Error
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 14:02 — with GitHub Actions Error
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 14:03 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 14:03 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 14:03 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 14:03 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 14:13 — with GitHub Actions Error
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 14:13 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 14:13 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 14:13 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 14:13 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 14:18 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 14:18 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 14:18 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 14:18 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 14:19 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 14:19 — with GitHub Actions Error
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 14:19 — with GitHub Actions Error
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests June 2, 2023 14:20 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 14:20 — with GitHub Actions Failure
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests June 2, 2023 14:20 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests June 2, 2023 14:20 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests September 13, 2023 14:54 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 13, 2023 14:54 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 13, 2023 14:54 — with GitHub Actions Inactive
glsdown
glsdown reviewed Sep 13, 2023
View reviewed changes
.github/workflows/ci_test_package.yml
Comment on lines -50 to +57
uses: rez0n/actions-github-release@main
- name: Checkout
id: latest_release
env:
token: ${{ secrets.GITHUB_TOKEN }}
repository: ${{ github.repository }}
type: "stable"
uses: actions/checkout@v3
with:
fetch-depth: 0
- run: |
output=$(git describe --tags --abbrev=0)
echo "::set-output name=release::$output"
Copy link
Contributor

@glsdown glsdown Sep 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remind me @jared-rimmer - what was the aim of this change? It's been a while since I looked at this. Or is it something that was deleted in a merge conflict situation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two slight concerns with it:

  1. I think set-output is being deprecated in favour of $GITHUB_OUTPUT instead.
  2. This won't allow for non-stable releases, or if we tag with something else. If this is the only way of getting it to work with Powershell, it might be worth having this only when it's PowerShell, and then retaining the original action for ubuntu

What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep your solution sounds good!

@glsdown glsdown had a problem deploying to Approve Integration Tests September 13, 2023 14:57 — with GitHub Actions Failure
@glsdown glsdown had a problem deploying to Approve Integration Tests September 13, 2023 14:57 — with GitHub Actions Failure
@glsdown glsdown had a problem deploying to Approve Integration Tests September 13, 2023 14:57 — with GitHub Actions Failure
@glsdown glsdown had a problem deploying to Approve Integration Tests September 13, 2023 14:57 — with GitHub Actions Failure
@glsdown glsdown had a problem deploying to Approve Integration Tests September 13, 2023 14:57 — with GitHub Actions Failure
@glsdown glsdown had a problem deploying to Approve Integration Tests September 13, 2023 14:57 — with GitHub Actions Failure
@glsdown glsdown had a problem deploying to Approve Integration Tests September 13, 2023 14:57 — with GitHub Actions Failure
@glsdown glsdown had a problem deploying to Approve Integration Tests September 13, 2023 14:57 — with GitHub Actions Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glsdown glsdown glsdown approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jared-rimmer @glsdown