Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Add windows_latest to Github workflow matrix OS #354

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[FEAT] Add windows_latest to Github workflow matrix OS #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e330420
Add windows_latest to Github workflow matrix OS
jared-rimmer Jun 2, 2023
9663a94
Add missing runs_on and use matrix.os
jared-rimmer Jun 2, 2023
de6d4a0
Refactor get latest release step
jared-rimmer Jun 2, 2023
84f7900
Add a checkout step before getting the release
jared-rimmer Jun 2, 2023
ace9ec4
Add run object to checkout
jared-rimmer Jun 2, 2023
b2b5c27
Remove with settings
jared-rimmer Jun 2, 2023
ad28fd5
Add fetch-depth
jared-rimmer Jun 2, 2023
4afd54a
Merge branch 'main' into feat/add-windows-os-to-github-workflows
glsdown Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions .github/workflows/ci_test_package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,21 +38,23 @@ jobs:
fail-fast: false # Don't fail one DWH if the others fail
matrix:
warehouse: ["snowflake", "bigquery"]
runs-on: ubuntu-latest
os: [ubuntu-latest, windows-latest]
runs-on: ${{ matrix.os }}
environment:
name: Approve Integration Tests
permissions:
contents: "read"
id-token: "write"

steps:
- name: Get latest release
uses: rez0n/actions-github-release@main
- name: Checkout
id: latest_release
env:
token: ${{ secrets.GITHUB_TOKEN }}
repository: ${{ github.repository }}
type: "stable"
uses: actions/checkout@v3
with:
fetch-depth: 0
- run: |
output=$(git describe --tags --abbrev=0)
echo "::set-output name=release::$output"
Comment on lines -50 to +57
Copy link
Contributor

@glsdown glsdown Sep 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remind me @jared-rimmer - what was the aim of this change? It's been a while since I looked at this. Or is it something that was deleted in a merge conflict situation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two slight concerns with it:

  1. I think set-output is being deprecated in favour of $GITHUB_OUTPUT instead.
  2. This won't allow for non-stable releases, or if we tag with something else. If this is the only way of getting it to work with Powershell, it might be worth having this only when it's PowerShell, and then retaining the original action for ubuntu

What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep your solution sounds good!


- name: Checkout latest release
uses: actions/checkout@v3
Expand Down Expand Up @@ -103,7 +105,8 @@ jobs:
warehouse: ["snowflake", "bigquery"]
# When supporting a new version, update the list here
version: ["1_3_0", "1_4_0", "1_5_0", "1_6_0"]
runs-on: ubuntu-latest
os: [ubuntu-latest, windows-latest]
runs-on: ${{ matrix.os }}
environment:
name: Approve Integration Tests
permissions:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/main_test_package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ jobs:
matrix:
warehouse: ["snowflake", "bigquery"]
version: ["1_3_0", "1_4_0", "1_5_0", "1_6_0"]
runs-on: ubuntu-latest
os: [ubuntu-latest, windows-latest]
runs-on: ${{ matrix.os }}
permissions:
contents: "read"
id-token: "write"
Expand Down
Loading