Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse_json({{ field }}, wide_number_mode=>'round') was added for the … #358

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

calkan-cue
Copy link
Contributor

@calkan-cue calkan-cue commented Jun 15, 2023

…bigquery

Overview

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)

What does this solve?

06:50:58  Running 1 on-run-end hook
06:50:58  Uploading model executions
06:51:02  Uploading seed executions
06:51:02  Uploading snapshot executions
06:51:02  Uploading test executions
06:51:02  Uploading exposures
06:51:05  Uploading tests
06:52:15  BigQuery adapter: https://console.cloud.google.com&page=queryresults
06:52:15  Database error while running on-run-end
06:52:15  
06:52:15  Finished running 11 incremental models, 23 view models in 0 hours 1 minutes and 58.26 seconds (118.26s).
06:52:16  
06:52:16  Completed with 1 error and 0 warnings:
06:52:16  
06:52:16  on-run-end failed, error:
06:52:16   Invalid input: Input number: 1686725407.683936 cannot round-trip through string representation; error in PARSE_JSON expression
06:52:16  
06:52:16  Done. PASS=34 WARN=0 ERROR=1 SKIP=0 TOTAL=35

Outstanding questions

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

@calkan-cue calkan-cue had a problem deploying to Approve Integration Tests June 15, 2023 14:19 — with GitHub Actions Failure
@calkan-cue calkan-cue had a problem deploying to Approve Integration Tests June 15, 2023 14:19 — with GitHub Actions Failure
@calkan-cue calkan-cue had a problem deploying to Approve Integration Tests June 15, 2023 14:19 — with GitHub Actions Failure
@jared-rimmer
Copy link
Member

Hi @calkan-cue thank you for the PR. At the moment this has been implemented in number of places outside of the macro where you have made the change.

Would you be able to remove all the other references so it's only done in a single place?

@calkan-cue calkan-cue temporarily deployed to Approve Integration Tests June 20, 2023 17:08 — with GitHub Actions Inactive
@calkan-cue calkan-cue temporarily deployed to Approve Integration Tests June 20, 2023 17:08 — with GitHub Actions Inactive
@calkan-cue calkan-cue temporarily deployed to Approve Integration Tests June 20, 2023 17:08 — with GitHub Actions Inactive
@calkan-cue calkan-cue temporarily deployed to Approve Integration Tests June 21, 2023 15:49 — with GitHub Actions Inactive
@calkan-cue calkan-cue temporarily deployed to Approve Integration Tests June 21, 2023 15:49 — with GitHub Actions Inactive
@calkan-cue calkan-cue temporarily deployed to Approve Integration Tests June 21, 2023 15:49 — with GitHub Actions Inactive
@calkan-cue calkan-cue temporarily deployed to Approve Integration Tests June 21, 2023 15:49 — with GitHub Actions Inactive
@calkan-cue calkan-cue temporarily deployed to Approve Integration Tests June 21, 2023 15:49 — with GitHub Actions Inactive
@calkan-cue calkan-cue temporarily deployed to Approve Integration Tests June 21, 2023 15:49 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer merged commit 7789aca into brooklyn-data:main Jun 21, 2023
@SPTKL
Copy link
Contributor

SPTKL commented Jun 30, 2023

Hi @jared-rimmer, how would this work? parse_json in the upload sql files is referenced as a bigquery sql function instead of a jinja macro

@glsdown glsdown mentioned this pull request Jul 21, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants