feat: add Jose to the website #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e (waiting on hover)
pneumatick
changed the title
|
Just request someone's review when you're ready! |
|
Visit the preview URL for this PR (updated for commit ba09115): https://ccv-brown-edu--pr259-jose-harvey-ssocpp60.web.app (expires Wed, 19 Jun 2024 18:18:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e6225babbaf68dadb99b2906d33811740e5d15cb |
eldu
requested changes
Jun 6, 2024
about/people.yml
Outdated
Comment on lines
442
to
443
| name: Jose Harvey | ||
| type: Part Time |
There was a problem hiding this comment.
I believe you need to add in the hyphen so it knows it's a separate entry. Right now you've overridded Melinda's entry
Suggested change
| name: Jose Harvey | |
| type: Part Time | |
| - name: Jose Harvey | |
| type: Part Time |
There was a problem hiding this comment.
Check out a YAML tutorial about arrays
images/people/jose_hover.jpg
Outdated
There was a problem hiding this comment.
The main and hover images have different extensions .jpg vs .jpeg. Unify that and I think it'll fix the hover
eldu
requested changes
Jun 10, 2024
eldu
approved these changes
Jun 12, 2024
Fix typo in biography Co-authored-by: Ellen Duong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added most of my profile information in people.yml; Added main picture (waiting on hover).
Note: This branch is not currently ready to merge.
Missing information: brown_directory_uuid, hover picture