Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Jose to the website #259

Merged
merged 6 commits into from
Jun 12, 2024
Merged

feat: add Jose to the website #259

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c4e39e4
Added most of my profile information in people.yml; Added main pictur…
pneumatick Jun 6, 2024
6f9541f
Added uuid
pneumatick Jun 6, 2024
6b510a0
Added hover picture
pneumatick Jun 6, 2024
5fce5cb
Implemented changes suggested by Ellen
pneumatick Jun 7, 2024
4332ca4
Merge branch 'main' into jose-harvey
pneumatick Jun 12, 2024
ba09115
Update about/people.yml
pneumatick Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions about/people.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,3 +439,12 @@ data:
brown_directory_uuid: 542a2511-9c28-4f0d-a20b-107e002929fb
bio: Melinda is a summer research intern working with the Computational Biology Core at CCV. She is an undergraduate student at Brown concentrating in Computational Biology. She loves matcha lattes and long walks in Providence.
image: melinda_main.jpg
name: Jose Harvey
type: Part Time
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you need to add in the hyphen so it knows it's a separate entry. Right now you've overridded Melinda's entry

Suggested change
name: Jose Harvey
type: Part Time
- name: Jose Harvey
type: Part Time

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out a YAML tutorial about arrays

team: Advanced Research Computing
subteam: Graphics, Software, and Data Core
title: Data Science Intern
github_username: pneumatick
brown_directory_uuid: aceb7ec3-763c-4179-83b2-96417dbacf9f
bio: Jose is a data science intern in the Advanced Reseach Computing division at CCV. He is an undergraduate student at the University of Rhode Island studying Computer Science. In his spare time, he enjoys reading, playing his guitar, drawing, and exploring new places.
pneumatick marked this conversation as resolved.
Show resolved Hide resolved
image: jose_main.jpeg
Binary file added images/people/jose_hover.jpg
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main and hover images have different extensions .jpg vs .jpeg. Unify that and I think it'll fix the hover

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/people/jose_main.jpeg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading