Multi-target .net dependencies explicitly per target, and add net8 support #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale: net6 target was depending on Logging.Abstractions v7.0.0 which creates issues in environments like azure functions when there are major version discrepancies.
|
@CBenghi If you get a chance can you review please? Since XIDS took dependency on ids-lib is causing an issue for us as we have a conflict with xbim.geometry v6 |
|
@CBenghi any chance you can take a look at this? Just needs the build no incrementing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: net6 target was depending on Logging.Abstractions v7.0.0 which creates issues in environments like azure functions when there are major version discrepancies.
Because ids-lib under net6 was referencing 7.0.0 logging abstractions while other libraries in a net6 app required 6.0.0 this was creating issues for us (e.g. xbim Geometry is targeting net6 and using 6.0.0 logging). While 7.0.0 is interface compatible with 6 some cases exist where it cause issues resolving an appropriate version, so I've split the ids-lib .net framework targeting explicitly for netstandard2, net6, and I've added explicit net7 and net8 targets.
Worth noting many orgs may not want 7.0 dependencies as its not long-term supported, unlike net6 & net8.
Upgrade testlib and codegen to net8 just to flush out any issues.
TODO: Assembly versions need updating for nuget publishing.