Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: zero coercion timeout removal bug #72

Merged
merged 1 commit into from
Jun 22, 2024
Merged

fix: zero coercion timeout removal bug #72

merged 1 commit into from
Jun 22, 2024

Conversation

guybedford
Copy link
Contributor

This fixes a bug where clearTimeout(null) could clear a valid timeout if one existed at timer id 0, by starting the timer ids from 1. Affected a real web platform test!

@guybedford guybedford mentioned this pull request Jun 22, 2024
Merged
tschneidereit
tschneidereit approved these changes Jun 22, 2024
View reviewed changes
Copy link
Member

@tschneidereit tschneidereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should've thought of that, apologies

@tschneidereit tschneidereit merged commit 3e5585e into main Jun 22, 2024
1 check passed
@tschneidereit tschneidereit deleted the invalid-timeout-clear branch June 22, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschneidereit tschneidereit tschneidereit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guybedford @tschneidereit