Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Skip Nav #1645

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Feat: Skip Nav #1645

merged 2 commits into from
Aug 14, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Aug 10, 2023

closes #1388

requires #1387 and #1613

What this PR does

  • Style the Skip Nav into a full-width div with yellow background
  • Works like the Skip Nav here https://www.gov.uk/

To test

  • When testing, do not have the developer console tool window open. The focus won't work.
  • On Desktop: Go to any page, like http://localhost:8000/mst
  • Click Tab on keyboard
  • Once the skip nav appears, click Enter
  • Click Tab again. You'll now be in the #main-content div and probably focused on a Call to Action button. You'll have skipped the Español button. You don't skip the Previous Page button though.
  • Skip Navs are generally Desktop features b/c it's for users using a keyboard, but it works fine on Mobile too.
  • Works better if you hide the Dev Mode bar. Hide it by adding d-none in base.html or adding .bg-danger { display: none;} to style.css

Screenshots

image image

@machikoyasuda machikoyasuda self-assigned this Aug 10, 2023
@machikoyasuda machikoyasuda added this to the Veterans milestone Aug 10, 2023
@github-actions github-actions bot added the front-end HTML/CSS/JavaScript and Django templates label Aug 10, 2023
@machikoyasuda machikoyasuda changed the title Skip Nav Feat: Skip Nav Aug 10, 2023
@machikoyasuda machikoyasuda linked an issue Aug 10, 2023 that may be closed by this pull request
2 tasks
Base automatically changed from feat/1387-focus-rings to dev August 11, 2023 18:27
@machikoyasuda machikoyasuda marked this pull request as ready for review August 11, 2023 18:28
@machikoyasuda machikoyasuda requested a review from a team as a code owner August 11, 2023 18:28
@machikoyasuda
Copy link
Member Author

Rebased with latest dev

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting approach to put the <a> on the outside and the container within, makes the whole Skip bar clickable 👍

@machikoyasuda machikoyasuda merged commit 035bb78 into dev Aug 14, 2023
4 checks passed
@machikoyasuda machikoyasuda deleted the feat/1388-skip-nav branch August 14, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a user, when I press tab, I want to see a skip to nav option
2 participants