Edits calitp-data-analysis packages versions so it works with python 3.11 #3357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vevetron
changed the title
vevetron
force-pushed
the
update_calitp_data_analysis
branch
from
51d645e
to
ba99fc5
Compare
vevetron
changed the title
evansiroky
approved these changes
May 24, 2024
added 2 commits
May 24, 2024 10:50
fix(calitp-data-analysis): locks down packages to what keeps sqlalchemy below 2.0.0 and code needs to be rewritten, hacky solution I know
vevetron
force-pushed
the
update_calitp_data_analysis
branch
from
ba99fc5
to
01615ec
Compare
This was referenced May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finding fixes so calitp-data-analysis actually gets built. Locks down packages so tests pass.
Previously sqlalchemy 2.0.3 was loaded and it did not like how the package was written - sqlalchemy 2.0+ has new ways to write certain functions.
In the future we should unlock the packages and rewrite the sql.py so it conforms to sqlalchemy 2.0.3.
Description
In #3355 didn't get built because github actions was building in python 3.9, not python 3.11
Type of change
How has this been tested?
Built locally with poetry install using python 3.11
Ran pytest
Post-merge follow-ups
Test poetry install of jupyter-single user using this package version